malformed xbar.var format (name needs VAR_ prefix)

[picatz]

After updating to the latest version, I ran into 7c935c5 which impacted a Vault xbar plugin I've been tinkering with. The plugin still worked, but the plugin page in the xbar app now throws an error due to a malformed format. The plugin continued to function thanks to the JSON config saved on disk from the old version, but I can no longer edit the value from the app because the variables don't have the VAR_ prefix.

# <xbar.var>string(VAULT_ADDR="http://localhost:8200"): Vault address.</xbar.var>
# <xbar.var>string(VAULT_TOKEN=""): Vault API token.</xbar.var>
# <xbar.var>string(VAULT_CACERT=""): Full path to the Vault CA cert.</xbar.var>
# <xbar.var>string(VAULT_CLIENT_CERT=""): Full path to the Vault client cert.</xbar.var>
# <xbar.var>string(VAULT_CLIENT_KEY=""): Full path to the Vault client key.</xbar.var>

These environment variables were helpful/easy as a plugin developer, since they are naturally supported by the vault binary on the system.

🤔 Would it make sense to continue supporting setting any environment variables from the config as a feature?

[matryer]

@picatz I think you're right. The VAR_ prefix was supposed to prevent clashes but maybe we can trust plugin developers a little more than this. I'll remove this constraint.

[matryer]

@picatz please try the latest release and let me know how that is for you.

[picatz]

Works with the latest release ( v2.0.33-beta ). Thank you!

[matryer]

No @picatz thank you.