Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Folders in the plugins directory get "executed" #651

Closed
gzphreak opened this issue Mar 19, 2021 · 5 comments
Closed

Folders in the plugins directory get "executed" #651

gzphreak opened this issue Mar 19, 2021 · 5 comments
Labels

Comments

@gzphreak
Copy link

gzphreak commented Mar 19, 2021

It would appear that xbar, when trying to execute all the scripts in the plugins directory, tries to execute directories. BitBar did not do this.
Screen Shot 2021-03-19 at 8 41 39 AM
The Dir function in pkg/plugins/plugin.go should include, in its ignore logic, something like this:

if file.IsDir() {
  // ignore  directories
  continue
}

I would have made a PR but the readme suggests opening an issue first.

Thanks for this project. 😄

@matryer
Copy link
Owner

matryer commented Mar 19, 2021

@gzphreak doh - nice catch. We'll fix this.

@matryer matryer added the bug label Mar 19, 2021
@gzphreak
Copy link
Author

Thanks!

@matryer
Copy link
Owner

matryer commented Mar 19, 2021

@@gzphreak please try the latest release and let me know if that's fixed it for you.

@gzphreak
Copy link
Author

@matryer The latest release ignores directories. Thanks for the quick turn around. ❤️

@matryer
Copy link
Owner

matryer commented Mar 19, 2021

@gzphreak most welcome - let me know if you notice any other annoyances. Have a nice weekend.

@matryer matryer closed this as completed Mar 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants