Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Font size in menu has decreased #623

Closed
magicus opened this issue Mar 10, 2021 · 11 comments
Closed

Font size in menu has decreased #623

magicus opened this issue Mar 10, 2021 · 11 comments

Comments

@magicus
Copy link

magicus commented Mar 10, 2021

At first I thought I was getting slightly mad, but I can swear that the menu text has changed in some of latest beta releases. It used to be the case (at least in BitBar) that the plugin output and the fixed text from xbar/BitBar was the same size. Now, the latter is as it used to be, but the former is smaller. See screenshot. (Effect is greater and easier to see when you compare with e.g. Time Machine drop down menu)
Screen Shot 2021-03-10 at 12 00 17

@matryer
Copy link
Owner

matryer commented Mar 10, 2021

@magicus You're right - although it's not entirely obvious why. Perhaps @leaanthony can shed some light on this, could be a new default in Wails.

matryer added a commit that referenced this issue Mar 10, 2021
@matryer
Copy link
Owner

matryer commented Mar 10, 2021

v2.0.17-beta has the new font size fix.

@matryer
Copy link
Owner

matryer commented Mar 10, 2021

@magicus please try the latest release and we can close this if you agree the font sizes are back to normal.

@leaanthony
Copy link
Collaborator

There's been no underlying change so this is pretty curious!

@matryer
Copy link
Owner

matryer commented Mar 10, 2021

OK well they're set explicitly for now. So closing this. Thanks everyone.

@matryer matryer closed this as completed Mar 10, 2021
@magicus
Copy link
Author

magicus commented Mar 10, 2021

Screen Shot 2021-03-10 at 22 45 31
Actually, the new beta is ... well... I'm sorry to say, but it's just at bad but the other way around -- now the font is too large. :-( The "Preferences" is still what I'd consider normal font size -- it's the same as in BitBar, and in other tray icon menues. But now the plugin output is larger than this...

matryer added a commit that referenced this issue Mar 11, 2021
@matryer
Copy link
Owner

matryer commented Mar 11, 2021

@magicus OK I'm going to try one more tweak that will go out in the next release. (will be v2.0.20-beta+)

@Joshfindit
Copy link

Joshfindit commented Mar 30, 2021

I was just noticing that my fonts are smaller with xbar than they are with BitBar.

image
xbar to the left of the dropbox icon, bitbar to the right

image

On my system (10.13.6 and xbar v2.0.37-beta), the BitBar font is the system default, and xbar is something else.

@matryer Is it possible to expose the default font/size/style as a preference in xbar? I feel like MacOS is not making this easy with the change in APis due to font rendering on HiDPI displays.

@leaanthony
Copy link
Collaborator

Will test on High Sierra and get back to you 👍

@leaanthony
Copy link
Collaborator

PR #677 should fix this. Screenshots from High Sierra 👍

@Joshfindit
Copy link

The reason that I asked about a preference is that, in my experience, stuff like this is extremely fiddly.

image
View in full to see that the tops and bottoms of the characters don't line up in the menubar. Line height for menus is bang-on though

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants