Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for validating alt_aliases of a canonical alias event. #824

Merged
merged 3 commits into from
Mar 16, 2020
Merged

Add tests for validating alt_aliases of a canonical alias event. #824

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ee082c9
Add tests for validating alt_aliases.
clokep Mar 3, 2020
4ed9264
Assert particular error codes.
clokep Mar 9, 2020
7afa389
Add an additional tests for M_BAD_ALIAS.
clokep Mar 9, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
79 changes: 79 additions & 0 deletions tests/30rooms/05aliases.pl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,6 +90,7 @@
}
)->SyTest::pass_on_done( "m.room.canonical_alias accepts present aliases" );
})->then( sub {
# Create an unknown, but valid alias name.
my $bad_alias = $room_alias =~ s/^#/#NOT-/r;

matrix_put_room_state( $user, $room_id,
Expand All @@ -99,6 +100,84 @@
}
)->main::expect_http_4xx
->SyTest::pass_on_done( "m.room.canonical_alias rejects missing aliases" );
})->then( sub {
# Create an invalid alias name (starts with % instead of #).
my $bad_alias = $room_alias =~ s/^#/%/r;

matrix_put_room_state( $user, $room_id,
type => "m.room.canonical_alias",
content => {
alias => $bad_alias,
}
)->main::expect_http_4xx
->SyTest::pass_on_done( "m.room.canonical_alias rejects invalid aliases" );
});
};

multi_test "Canonical alias can include alt_aliases",
requires => [ local_user_fixture(), room_alias_name_fixture() ],

do => sub {
my ( $user, $room_alias_name ) = @_;

my ( $room_id, $room_alias );

matrix_create_room( $user,
room_alias_name => $room_alias_name,
)->then( sub {
( $room_id, $room_alias ) = @_;

matrix_put_room_state( $user, $room_id,
type => "m.room.canonical_alias",
content => {
alias => $room_alias,
alt_aliases => [ $room_alias ],
}
)->SyTest::pass_on_done( "m.room.canonical_alias accepts present aliases" );
})->then( sub {
# Create an unknown, but valid alias name.
my $bad_alias = $room_alias =~ s/^#/#NOT-/r;

matrix_put_room_state( $user, $room_id,
type => "m.room.canonical_alias",
content => {
alias => $room_alias,
alt_aliases => [ $bad_alias ],
}
)->main::expect_matrix_error( 404, "M_NOT_FOUND" )
->SyTest::pass_on_done( "m.room.canonical_alias rejects missing aliases" );
richvdh marked this conversation as resolved.
Show resolved Hide resolved
})->then( sub {
# Create an invalid alias name (starts with % instead of #).
my $bad_alias = $room_alias =~ s/^#/%/r;

matrix_put_room_state( $user, $room_id,
type => "m.room.canonical_alias",
content => {
alias => $room_alias,
alt_aliases => [ $bad_alias ],
}
)->main::expect_matrix_error( 400, "M_INVALID_PARAM" )
->SyTest::pass_on_done( "m.room.canonical_alias rejects invalid aliases" );
})->then( sub {
# Create a second room with an alias on it.
my $other_alias_name = $room_alias_name . "2";

matrix_create_room( $user,
room_alias_name => $other_alias_name,
)->then( sub {
my ( $other_room_id, $other_room_alias ) = @_;

# Attempt to set a canonical alias for the original room using an
# alias from the second room.
matrix_put_room_state( $user, $room_id,
type => "m.room.canonical_alias",
content => {
alias => $room_alias,
alt_aliases => [ $other_room_alias ],
}
)->main::expect_matrix_error( 400, "M_BAD_ALIAS" )
->SyTest::pass_on_done( "m.room.canonical_alias rejects alias pointing to different room" );
})
});
};

Expand Down