Have the in-built identity server support v2 #689
Merged
+593
−195
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richvdh
requested changes
Sep 4, 2019
There was a problem hiding this comment.
I think this looks generally good, modulo a few nits.
Factoring out each endpoint to its own function is a great idea, but the diff would have been an order of magnitude clearer (and hence it would be easier to review) if the refactor had been in a separate PR to the new functionality...
|
Added docstrings for every function. |
richvdh
requested changes
Sep 9, 2019
richvdh
approved these changes
Sep 9, 2019
anoadragon453
added a commit
that referenced
this pull request
Mar 18, 2020
…ase-v1.4.0 * origin/release-v1.4.0: (36 commits) Improve logging for a failing test (#709) Make 3PID binding tests use /account/3pid/bind ala MSC2290 (#703) Use unstable prefix for 3PID unbind API Add support for handling email validation challenges (#707) do requestToken before adding a 3pid (#706) Configure synapse to use the test mail server (#705) Implement a mail server to help with 3pid testing (#704) federated_rooms_fixture (#701) Use Sytest develop for Dendrite's master branch (#700) Don't assume atomicity Fix flakiness due to create_room_synced (#702) Don't require an avatar_url Replace HOMESERVER_INFO incantations (#699) add some logging for flaky sync test (#698) Fix problems when using hash Accept access_token instead of id_access_token on the IS, accept Authorization header (#697) Use hash and handle variable sized final chunk Have the in-built identity server support v2 (#689) Add tests for 3PID /unbind API (#691) Fix typo ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add all of the v2 identity server endpoints to Sytest's built-in identity server. This is independent of any of the Synapse changes currently in-flight.
Additionally, change the identity server tests to use these v2 endpoints.
This essentially just involves switching the endpoints to v2 and including an
id_access_tokenparameter at the top-level of the JSON, or in a query parameter. I tried to reuse functions wherever possible.The
id_access_tokenis hard-coded, as there isn't much point retrieving it via OpenID as we're using a built-in Sytest identity server, which we don't need to test. Sydent's OpenID functionality is handled by matrix-is-tester.