Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 'Inbound federation correctly soft fails events' #1371

Merged
merged 1 commit into from
Nov 16, 2023

Conversation

erikjohnston
Copy link
Member

Example failure:

Error: FAILURE: #714: Inbound federation correctly soft fails events
Logs
  # Started: 2023-11-16 11:06:1[9](https://github.com/matrix-org/synapse/actions/runs/6889752308/job/18741444869?pr=16643#step:8:10).683
  # Ended: 2023-11-16 11:06:20.1[10](https://github.com/matrix-org/synapse/actions/runs/6889752308/job/18741444869?pr=16643#step:8:11)
  # SyTest::Federation::Datastore=HASH(0x560d97f08098) has no event id '$aupmJZ2kG7Td8jeW06Dk-8BcVKzNoNLb56b3OOLlRc0' at tests/50federation/52soft-fail.pl line 120.
  # 0.034925: Registered new user @anon-2023[11](https://github.com/matrix-org/synapse/actions/runs/6889752308/job/18741444869?pr=16643#step:8:12)16_110041-868:localhost:8800
  # 0.290339: Joined room
  # 0.317274: Got join down sync
  # 0.400517: Body
  # { event_id => "\$aupmJZ2kG7Td8jeW06Dk-8BcVKzNoNLb56b3OOLlRc0" }
  # 0.415683: Blocked new messages
  # 0.416053: Sending blocked event $YrtlC2paoPAwqiTPNMfibPyZi9e3dpNn1bhb_RC58gQ
  # {
  #   auth_events      => [
  #                         "\$jFjRiizTsoyTbODG3UOkmzz2a0EKmVLLw0jow9l8DhY",
  #                         "\$o835Uvo15VUvLjOr1M6oKjtIPdXttdFk08e1H6qevvk",
  #                         "\$iCZmJ_8GsxwCrrV4oHsMcbU5FYDcelfeqVuKrrdmIlw",
  #                         "\$j3Jp2vtZcINaMX6Ku-skKGNqxQ0qSBTzEZcfj_9Y5Bc",
  #                       ],
  #   content          => { body => "Denied" },
  #   depth            => JSON::number(8),
  #   hashes           => { sha256 => "3csuXjYw1yMpZs/yjUgWQIPNNVR6FDMXn4895yzfB5k" },
  #   origin_server_ts => JSON::number(1700[13](https://github.com/matrix-org/synapse/actions/runs/6889752308/job/18741444869?pr=16643#step:8:14)2780099),
  #   prev_events      => ["\$j3Jp2vtZcINaMX6Ku-skKGNqxQ0qSBTzEZcfj_9Y5Bc"],
  #   room_id          => "!bfUpdvWJvZvKdsfNvl:localhost:8800",
  #   sender           => "\@__ANON__-96:localhost:39621",
  #   signatures       => {
  #                         "localhost:39621" => {
  #                           "ed255[19](https://github.com/matrix-org/synapse/actions/runs/6889752308/job/18741444869?pr=16643#step:8:20):1" => "di7EqrbADJXChIWd+DofuCQG5pmt77ZN5Lzz9T/hFFG/htLa2ltj2Lm/YEGr80yCbhmv4gQ3rpP2A1OtZkmeBw",
  #                         },
  #                       },
  #   type             => "m.room.message",
  # }

@erikjohnston erikjohnston requested a review from a team as a code owner November 16, 2023 11:22
@erikjohnston erikjohnston merged commit 4914c2f into develop Nov 16, 2023
9 checks passed
@erikjohnston erikjohnston deleted the erikj/fix_failing_test branch November 16, 2023 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants