Outlier/rejected tests for /state and /state_ids
#1211
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Extend the tests for `/state` and `/state_ids` to check the behaviour on outliers and rejected events. The rejected-event behaviour has always been to return a 404, but we add a test to make sure it stays that way. The outlier behaviour is changed by matrix-org/synapse#12087.
clokep
reviewed
Mar 14, 2022
tests/50federation/00prepare.pl
Outdated
Comment on lines
219
to
222
| auth_events => $room->make_event_refs( | ||
| $room->get_current_state_event( "m.room.create" ), | ||
| $room->get_current_state_event( "m.room.power_levels" ), | ||
| $room->get_current_state_event( "m.room.member", $sending_user_id ), |
There was a problem hiding this comment.
Looking at Room->create_event, I think these are essentially the default auth_events (although that seems to also specify m.room.join_rules). Am I missing something or are we just being specific here?
There was a problem hiding this comment.
yeah, I don't know why I did this.
clokep
approved these changes
Mar 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extend the tests for
/stateand/state_idsto check the behaviour on outliers and rejected events.The rejected-event behaviour has always been to return a 404, but we add a test to make sure it stays that way.
The outlier behaviour is changed by matrix-org/synapse#12087.