Publish docker images via GHA #1134
Conversation
> The workflow is not valid. .github/workflows/docker.yml: Anchors are not currently supported. Remove the anchor 'buildx
already exists at the org level in the primary sytest repo
interesting to know it's possible, but I don't understand what it's doing and it hasn't saved any time. One for a rainy day.
| strategy: | ||
| matrix: | ||
| include: | ||
| - base_image: ubuntu:bionic |
There was a problem hiding this comment.
I don't know if this PR is the time for this or not, but @richvdh told me not to use bionic when I was asking about which image to use — because it's old.
Should we be bumping this to something like focal (20.04 LTS) (or hirsute [21.04] though probably not this one because non-LTS releases run out of life fairly quickly)?
There was a problem hiding this comment.
I generally prefer debian to ubuntu for this sort of thing - it has a longer support lifetime than the non-LTS ubuntus, and is bettter maintained than the LTS ones
suggest debian:bullseye-slim.
There was a problem hiding this comment.
Can do. (I was just trying to replicate the existing behaviour as faithfully as I could.)
There was a problem hiding this comment.
On second thoughts, I'll make that a second PR.
DMRobertson
requested review from
a team,
reivilibre and
richvdh
and removed request for
a team
|
LGTM otherwise |
Co-authored-by: reivilibre <38398653+reivilibre@users.noreply.github.com>
I tested this by running on my repo with an access token for my dockerhub account.
This run shows what a successful workflow should look like.
To publish these images to
matrixdotorgwe'll need an access token secret in this repository. I've requsted that in vector-im/sre-internal#162.