Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Fix assertions being thrown by the EventsStream update function #7337

Merged
merged 4 commits into from
Apr 24, 2020

Commits on Apr 23, 2020

  1. Remove 'limit' param from get_repl_stream_updates API

    there doesn't seem to be much point in passing this limit all around, since
    both sides agree it's meant to be 100.
    richvdh committed Apr 23, 2020
    Configuration menu
    Copy the full SHA
    23b2826 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    9cbdfb3 View commit details
    Browse the repository at this point in the history

Commits on Apr 24, 2020

  1. Fix EventsStream raising assertions when it falls behind

    Figuring out how to correctly limit updates from this stream without dropping
    entries is far more complicated than just counting the number of rows being
    returned. We need to consider each query separately and, if any one query hits
    the limit, truncate the results from the others.
    
    I think this also fixes some potentially long-standing bugs where events or
    state changes could get missed if we hit the limit on either query.
    richvdh committed Apr 24, 2020
    Configuration menu
    Copy the full SHA
    ce428a1 View commit details
    Browse the repository at this point in the history
  2. changelog

    richvdh committed Apr 24, 2020
    Configuration menu
    Copy the full SHA
    3655eaf View commit details
    Browse the repository at this point in the history