Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Use v1 endpoints for appservices #6460

Closed
wants to merge 6 commits into from
Closed

Conversation

Half-Shot
Copy link
Collaborator

@Half-Shot Half-Shot commented Dec 3, 2019

Fixes #3780

This PR updates the prefix of all appservice endpoints to v1 to be inline with the AS spec. This change however is extremely breaking as currently all matrix-org bridges rely on the old behaviour. Comments welcome on how we could support both (not as simple as checking for 404s, as that's a valid response for some of these endpoints).

@Half-Shot Half-Shot marked this pull request as ready for review December 4, 2019 11:37
@Half-Shot Half-Shot added the A-Spec-Compliance places where synapse does not conform to the spec label Dec 4, 2019
@Half-Shot Half-Shot requested a review from a team December 4, 2019 11:50
@richvdh
Copy link
Member

richvdh commented Dec 4, 2019

@Half-Shot have you looked at what's wrong with the CI?

@Half-Shot
Copy link
Collaborator Author

Looking into it now.

Copy link
Member

@richvdh richvdh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh I see, you know this is a breaking change.

How about updating the AS config file to include the version of the AS API the AS supports?

(we'd need to make the requests by synapse actually match the specced format, as per #6457)

@Half-Shot
Copy link
Collaborator Author

How about updating the AS config file to include the version of the AS API the AS supports?

We could do, although since the registration file format is also part of the spec we would also need to spec that.

@Half-Shot
Copy link
Collaborator Author

With much sadness, I present matrix-org/matrix-spec-proposals#2379

@richvdh
Copy link
Member

richvdh commented Jun 11, 2020

@Half-Shot are you still interested in working on this? what's the situation?

@Half-Shot
Copy link
Collaborator Author

Yes, need to figure out what I'm doing with matrix-org/matrix-spec-proposals#2379

@clokep clokep added the X-Awaiting-Changes A contributed PR which needs changes and re-review before it can be merged label Jun 16, 2020
@erikjohnston
Copy link
Member

I'm going to close this as it appears blocked on the MSC

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A-Spec-Compliance places where synapse does not conform to the spec X-Awaiting-Changes A contributed PR which needs changes and re-review before it can be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Call appservices with /_matrix/app/v1
4 participants