This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
Add option to disable searching in the user dir #4895
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We still populate it, as it can still be accessed via the admin API.
Codecov Report
@@ Coverage Diff @@
## develop #4895 +/- ##
===========================================
- Coverage 77.96% 77.95% -0.01%
===========================================
Files 326 326
Lines 33958 33962 +4
Branches 5601 5602 +1
===========================================
Hits 26474 26474
- Misses 5863 5867 +4
Partials 1621 1621 |
richvdh
suggested changes
Mar 19, 2019
Co-Authored-By: erikjohnston <erikj@jki.re>
Two things: 1) there's an admin API that uses user dir that isn't disabled, and 2) we'd want to have some way of correctly restarting the insertions if we flipped it off and on, which I'd like to avoid for now. |
erikjohnston
commented
Mar 20, 2019
| @@ -59,6 +59,12 @@ def on_POST(self, request): | |||
| requester = yield self.auth.get_user_by_req(request, allow_guest=False) | |||
| user_id = requester.user.to_string() | |||
|
|
|||
| if not self.hs.config.user_directory_search_enabled: | |||
There was a problem hiding this comment.
I haven't moved that into __init__ as there's no way of getting at servlets after they're set up afaik. We could do various contortions in the test to make it work, but I don't know whether that is better or worse.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We still populate it, as it can still be accessed via the admin API.