This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
Allow passing --daemonize to workers #4853
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richvdh
previously requested changes
Mar 13, 2019
There was a problem hiding this comment.
This adds a whole bunch of other settings to the --help output:
server:
-D, --daemonize Daemonize the home server
--print-pidfile Print the path to the pidfile just before daemonizing
--manhole PORT Turn on the twisted telnet manhole service on the
given port.
database:
-d SQLITE_DATABASE_PATH, --database-path SQLITE_DATABASE_PATH
The path to a sqlite database to use.
logging:
-v, --verbose The verbosity level. Specify multiple times to
increase verbosity. (Ignored if --log-config is
specified.)
-f LOG_FILE, --log-file LOG_FILE
File to log to. (Ignored if --log-config is
specified.)
--log-config LOG_CONFIG
Python logging config file
-n, --no-redirect-stdio
Do not redirect stdout/stderr to the log
registration:
--enable-registration
Enable registration for new users.
I don't think that any of the others actually work, so I don't think we should do this.
Codecov Report
@@ Coverage Diff @@
## develop #4853 +/- ##
===========================================
- Coverage 75.34% 75.32% -0.02%
===========================================
Files 340 340
Lines 34939 34953 +14
Branches 5722 5727 +5
===========================================
+ Hits 26324 26328 +4
- Misses 7000 7008 +8
- Partials 1615 1617 +2 |
|
Good point well made |
|
Okay, this should now correctly handle all the options. There is possibly an argument that we shouldn't support some of them, but we should be consistent across master and workers. The only thing that is possibly slightly odd here is |
erikjohnston
requested review from
richvdh and
a team
and removed request for
richvdh
richvdh
reviewed
Mar 15, 2019
| @@ -28,7 +28,7 @@ def read_config(self, config): | |||
| if self.worker_app == "synapse.app.homeserver": | |||
| self.worker_app = None | |||
|
|
|||
| self.worker_listeners = config.get("worker_listeners") | |||
| self.worker_listeners = config.get("worker_listeners", []) | |||
There was a problem hiding this comment.
this looks like it will fix #4783 ?
richvdh
added a commit
that referenced
this pull request
Apr 7, 2020
We pass --daemonize on the commandline, which (since at least #4853) overrides whatever the config file, so there is no need for it to be set in the config file.
richvdh
added a commit
that referenced
this pull request
Apr 8, 2020
We pass --daemonize on the commandline, which (since at least #4853) overrides whatever the config file, so there is no need for it to be set in the config file.
phil-flex
pushed a commit
to phil-flex/synapse
that referenced
this pull request
Jun 16, 2020
We pass --daemonize on the commandline, which (since at least matrix-org#4853) overrides whatever the config file, so there is no need for it to be set in the config file.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is broadly to make life easier with sytest (c.f. matrix-org/sytest#573)