Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Deduplicate some code in synapse.app #4567

Merged
merged 10 commits into from
Feb 8, 2019
Merged

Deduplicate some code in synapse.app #4567

merged 10 commits into from
Feb 8, 2019

Conversation

hawkowl
Copy link
Contributor

@hawkowl hawkowl commented Feb 5, 2019

No description provided.

@hawkowl hawkowl requested a review from a team February 5, 2019 12:08
@codecov-io
Copy link

codecov-io commented Feb 5, 2019

Codecov Report

Merging #4567 into develop will increase coverage by 0.17%.
The diff coverage is 55.31%.

@@             Coverage Diff             @@
##           develop    #4567      +/-   ##
===========================================
+ Coverage    74.89%   75.06%   +0.17%     
===========================================
  Files          338      338              
  Lines        34511    34455      -56     
  Branches      5620     5615       -5     
===========================================
+ Hits         25846    25863      +17     
+ Misses        7085     7010      -75     
- Partials      1580     1582       +2

richvdh
richvdh previously requested changes Feb 6, 2019
synapse/app/_base.py Show resolved Hide resolved
synapse/app/homeserver.py Show resolved Hide resolved
synapse/app/homeserver.py Show resolved Hide resolved
synapse/app/_base.py Outdated Show resolved Hide resolved
synapse/app/_base.py Outdated Show resolved Hide resolved
@hawkowl hawkowl requested a review from erikjohnston February 8, 2019 16:25
@erikjohnston erikjohnston mentioned this pull request Feb 8, 2019
Copy link
Member

@erikjohnston erikjohnston left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, modulo CI passing

@hawkowl hawkowl merged commit 9cd33d2 into develop Feb 8, 2019
@hawkowl hawkowl deleted the hawkowl/dedupe-start branch February 8, 2019 17:26
richvdh added a commit that referenced this pull request Feb 14, 2019
Synapse 0.99.1 (2019-02-14)
===========================

Features
--------

- Include m.room.encryption on invites by default ([\#3902](#3902))
- Federation OpenID listener resource can now be activated even if federation is disabled ([\#4420](#4420))
- Synapse's ACME support will now correctly reprovision a certificate that approaches its expiry while Synapse is running. ([\#4522](#4522))
- Add ability to update backup versions ([\#4580](#4580))
- Allow the "unavailable" presence status for /sync.
  This change makes Synapse compliant with r0.4.0 of the Client-Server specification. ([\#4592](#4592))
- There is no longer any need to specify `no_tls`: it is inferred from the absence of TLS listeners ([\#4613](#4613), [\#4615](#4615), [\#4617](#4617), [\#4636](#4636))
- The default configuration no longer requires TLS certificates. ([\#4614](#4614))

Bugfixes
--------

- Copy over room federation ability on room upgrade. ([\#4530](#4530))
- Fix noisy "twisted.internet.task.TaskStopped" errors in logs ([\#4546](#4546))
- Synapse is now tolerant of the `tls_fingerprints` option being None or not specified. ([\#4589](#4589))
- Fix 'no unique or exclusion constraint' error ([\#4591](#4591))
- Transfer Server ACLs on room upgrade. ([\#4608](#4608))
- Fix failure to start when not TLS certificate was given even if TLS was disabled. ([\#4618](#4618))
- Fix self-signed cert notice from generate-config. ([\#4625](#4625))
- Fix performance of `user_ips` table deduplication background update ([\#4626](#4626), [\#4627](#4627))

Internal Changes
----------------

- Change the user directory state query to use a filtered call to the db instead of a generic one. ([\#4462](#4462))
- Reject federation transactions if they include more than 50 PDUs or 100 EDUs. ([\#4513](#4513))
- Reduce duplication of ``synapse.app`` code. ([\#4567](#4567))
- Fix docker upload job to push -py2 images. ([\#4576](#4576))
- Add port configuration information to ACME instructions. ([\#4578](#4578))
- Update MSC1711 FAQ to calrify .well-known usage ([\#4584](#4584))
- Clean up default listener configuration ([\#4586](#4586))
- Clarifications for reverse proxy docs ([\#4607](#4607))
- Move ClientTLSOptionsFactory init out of `refresh_certificates` ([\#4611](#4611))
- Fail cleanly if listener config lacks a 'port' ([\#4616](#4616))
- Remove redundant entries from docker config ([\#4619](#4619))
- README updates ([\#4621](#4621))
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants