This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
Remove unnecessary resolve_events_with_state_map #3737
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We only ever used the synchronous resolve_events_with_state_map in one place, which is trivial to replace with the async version.
|
@erikjohnston this is missing a news entry |
hawkowl
reviewed
Sep 3, 2018
changelog.d/3786.misc
Outdated
| @@ -0,0 +1 @@ | |||
| Add initial implementation of new state resolution algorithm | |||
There was a problem hiding this comment.
this changelog seems out of place though
There was a problem hiding this comment.
Turns out git isn't psychic and needs to be explicitly told to switch branch.
erikjohnston
force-pushed
the
erikj/remove_redundant_state_func
branch
from
eb2f46c to
06ee2b7
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We only ever used the synchronous resolve_events_with_state_map in one
place, which is trivial to replace with the async version.