Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Remove database differentiation in _get_state_groups_from_groups_txn - SQLite supports recursive queries #14531

Closed
wants to merge 10 commits into from
Closed

Remove database differentiation in _get_state_groups_from_groups_txn - SQLite supports recursive queries #14531

wants to merge 10 commits into from

Commits on Nov 23, 2022

  1. We can use recursive queries in our supported SQLite version range 

    Follow-up to #14527
    @MadLittleMods
    MadLittleMods committed Nov 23, 2022
    Configuration menu
    Copy the full SHA
    5b4f3ac View commit details
    Browse the repository at this point in the history

  2. Add changelog

    @MadLittleMods
    MadLittleMods committed Nov 23, 2022
    Configuration menu
    Copy the full SHA
    f0ee9f8 View commit details
    Browse the repository at this point in the history

  3. Gate Postgres setting to Postgres

    @MadLittleMods
    MadLittleMods committed Nov 23, 2022
    Configuration menu
    Copy the full SHA
    76c6e50 View commit details
    Browse the repository at this point in the history

Commits on May 11, 2023

  1. Merge branch 'develop' into madlittlemods/remove-sqlite-tech-debt-in_… 

    …get_state_groups_from_groups_txn
    @MadLittleMods
    MadLittleMods committed May 11, 2023
    Configuration menu
    Copy the full SHA
    95a9e03 View commit details
    Browse the repository at this point in the history

Commits on May 12, 2023

  1. Remove SELECT DISTINCT ON syntax that's incompatible with SQLite 

    See #14531 (comment)

This does mean that I had to leave one SQLite specific query in place.
But at least we're using the same recursive query pattern now.
    @MadLittleMods
    MadLittleMods committed May 12, 2023
    Configuration menu
    Copy the full SHA
    8b103f4 View commit details
    Browse the repository at this point in the history

  2. Fix (select1) union (select2) clauses in SQLite (parenthesis not al… 

    …lowed)

See #14531 (comment)
    @MadLittleMods
    MadLittleMods committed May 12, 2023
    Configuration menu
    Copy the full SHA
    a790a45 View commit details
    Browse the repository at this point in the history

  3. Only select state_group when we have to

    @MadLittleMods
    MadLittleMods committed May 12, 2023
    Configuration menu
    Copy the full SHA
    d42df27 View commit details
    Browse the repository at this point in the history

  4. Fix grabbing the oldest state_group instead of the most-recent

    @MadLittleMods
    MadLittleMods committed May 12, 2023
    Configuration menu
    Copy the full SHA
    51ff192 View commit details
    Browse the repository at this point in the history

  5. More specific to SQLite3

    @MadLittleMods
    MadLittleMods committed May 12, 2023
    Configuration menu
    Copy the full SHA
    3b72249 View commit details
    Browse the repository at this point in the history

  6. Remove debug log

    @MadLittleMods
    MadLittleMods committed May 12, 2023
    Configuration menu
    Copy the full SHA
    8c8c9a6 View commit details
    Browse the repository at this point in the history