Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Keep track when we try and fail to process a pulled event #13589

Merged
merged 34 commits into from
Sep 14, 2022
Merged

Keep track when we try and fail to process a pulled event #13589

merged 34 commits into from
Sep 14, 2022

Commits on Aug 23, 2022

  1. Keep track when we tried to backfill an event

    @MadLittleMods
    MadLittleMods committed Aug 23, 2022
    Configuration menu
    Copy the full SHA
    e0d7fab View commit details
    Browse the repository at this point in the history

Commits on Aug 25, 2022

  1. Record in some fail spots

    @MadLittleMods
    MadLittleMods committed Aug 25, 2022
    Configuration menu
    Copy the full SHA
    b8d55d3 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'develop' into madlittlemods/keep-track-when-we-tried-to… 

    …-backfill-an-event
    @MadLittleMods
    MadLittleMods committed Aug 25, 2022
    Configuration menu
    Copy the full SHA
    f63d823 View commit details
    Browse the repository at this point in the history

  3. Record and clear attempts

    @MadLittleMods
    MadLittleMods committed Aug 25, 2022
    Configuration menu
    Copy the full SHA
    bec26e2 View commit details
    Browse the repository at this point in the history

  4. Add changelog

    @MadLittleMods
    MadLittleMods committed Aug 25, 2022
    Configuration menu
    Copy the full SHA
    fee37c3 View commit details
    Browse the repository at this point in the history

  5. Remove from when spam checker fails 

    See #13589 (comment)
    @MadLittleMods
    MadLittleMods committed Aug 25, 2022
    Configuration menu
    Copy the full SHA
    d1290be View commit details
    Browse the repository at this point in the history

  6. Custom upsert to increment 

    See #13589 (comment)
    @MadLittleMods
    MadLittleMods committed Aug 25, 2022
    Configuration menu
    Copy the full SHA
    f9119d0 View commit details
    Browse the repository at this point in the history

  7. Fix lints

    @MadLittleMods
    MadLittleMods committed Aug 25, 2022
    Configuration menu
    Copy the full SHA
    f5c6fe7 View commit details
    Browse the repository at this point in the history

  8. Remove extra whitespace

    @MadLittleMods
    MadLittleMods committed Aug 25, 2022
    Configuration menu
    Copy the full SHA
    16ebec0 View commit details
    Browse the repository at this point in the history

  9. Move to correct folder

    @MadLittleMods
    MadLittleMods committed Aug 25, 2022
    Configuration menu
    Copy the full SHA
    ce07aa1 View commit details
    Browse the repository at this point in the history

  10. Set the version back

    @MadLittleMods
    MadLittleMods committed Aug 25, 2022
    Configuration menu
    Copy the full SHA
    5811ba1 View commit details
    Browse the repository at this point in the history

  11. Fix TypeError: not all arguments converted during string formatting

    @MadLittleMods
    MadLittleMods committed Aug 25, 2022
    Configuration menu
    Copy the full SHA
    cf2b093 View commit details
    Browse the repository at this point in the history

Commits on Aug 26, 2022

  1. Add test to make sure failed backfill attempts are recorded

    @MadLittleMods
    MadLittleMods committed Aug 26, 2022
    Configuration menu
    Copy the full SHA
    cbb4194 View commit details
    Browse the repository at this point in the history

  2. Clean up test

    @MadLittleMods
    MadLittleMods committed Aug 26, 2022
    Configuration menu
    Copy the full SHA
    621c5d3 View commit details
    Browse the repository at this point in the history

  3. Fix comments

    @MadLittleMods
    MadLittleMods committed Aug 26, 2022
    Configuration menu
    Copy the full SHA
    75c07bb View commit details
    Browse the repository at this point in the history

  4. Add test for clearing backfill attempts

    @MadLittleMods
    MadLittleMods committed Aug 26, 2022
    Configuration menu
    Copy the full SHA
    783cce5 View commit details
    Browse the repository at this point in the history

  5. Maybe a better comment

    @MadLittleMods
    MadLittleMods committed Aug 26, 2022
    Configuration menu
    Copy the full SHA
    54ef84b View commit details
    Browse the repository at this point in the history

Commits on Aug 31, 2022

  1. Update table name with "failed" and include room_id in the primary key 

    See:

 - #13589 (comment)
 - #13589 (comment)
 - #13589 (comment)
 - #13589 (comment)
    @MadLittleMods
    MadLittleMods committed Aug 31, 2022
    Configuration menu
    Copy the full SHA
    e4192d7 View commit details
    Browse the repository at this point in the history

  2. Rename to record_event_failed_backfill_attempt 

    See #13589 (comment)
    @MadLittleMods
    MadLittleMods committed Aug 31, 2022
    Configuration menu
    Copy the full SHA
    7a44932 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'develop' into madlittlemods/keep-track-when-we-tried-to… 

    …-backfill-an-event
    @MadLittleMods
    MadLittleMods committed Aug 31, 2022
    Configuration menu
    Copy the full SHA
    86d98ca View commit details
    Browse the repository at this point in the history

Commits on Sep 1, 2022

  1. Add _unsafe_to_upsert_tables check 

    See #13589 (comment)
    @MadLittleMods
    MadLittleMods committed Sep 1, 2022
    Configuration menu
    Copy the full SHA
    1464101 View commit details
    Browse the repository at this point in the history

  2. Add foreign key references 

    See #13589 (comment)
    @MadLittleMods
    MadLittleMods committed Sep 1, 2022
    Configuration menu
    Copy the full SHA
    71c7738 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'develop' into madlittlemods/keep-track-when-we-tried-to… 

    …-backfill-an-event
    @MadLittleMods
    MadLittleMods committed Sep 1, 2022
    Configuration menu
    Copy the full SHA
    df8c76d View commit details
    Browse the repository at this point in the history

  4. Remove reference to event that won't be in the events table 

    See #13589 (comment)
    @MadLittleMods
    MadLittleMods committed Sep 1, 2022
    Configuration menu
    Copy the full SHA
    d45b078 View commit details
    Browse the repository at this point in the history

Commits on Sep 9, 2022

  1. Merge branch 'develop' into madlittlemods/keep-track-when-we-tried-to… 

    …-backfill-an-event
    @MadLittleMods
    MadLittleMods committed Sep 9, 2022
    Configuration menu
    Copy the full SHA
    33ad64e View commit details
    Browse the repository at this point in the history

  2. Remove emulated upsert code (all of our dbs no support it) 

    We now specify a SQLite version that supports upserts natively
so we no longer need the emulated version,
#13760

See:

 - #13589 (comment)
 - #13589 (comment)
    @MadLittleMods
    MadLittleMods committed Sep 9, 2022
    Configuration menu
    Copy the full SHA
    63bec99 View commit details
    Browse the repository at this point in the history

  3. Table rename event_failed_pull_attempts 

    See #13589 (comment)
    @MadLittleMods
    MadLittleMods committed Sep 9, 2022
    Configuration menu
    Copy the full SHA
    31d7502 View commit details
    Browse the repository at this point in the history

  4. Add last_cause column 

    See #13589 (comment)
    @MadLittleMods
    MadLittleMods committed Sep 9, 2022
    Configuration menu
    Copy the full SHA
    0b5f1db View commit details
    Browse the repository at this point in the history

Commits on Sep 12, 2022

  1. Merge branch 'develop' into madlittlemods/keep-track-when-we-tried-to… 

    …-backfill-an-event
    @MadLittleMods
    MadLittleMods committed Sep 12, 2022
    Configuration menu
    Copy the full SHA
    4ce7709 View commit details
    Browse the repository at this point in the history

Commits on Sep 13, 2022

  1. Merge branch 'develop' into madlittlemods/keep-track-when-we-tried-to… 

    …-backfill-an-event
    @MadLittleMods
    MadLittleMods committed Sep 13, 2022
    Configuration menu
    Copy the full SHA
    d3a1f84 View commit details
    Browse the repository at this point in the history

  2. Update schema version summary

    @MadLittleMods
    MadLittleMods committed Sep 13, 2022
    Configuration menu
    Copy the full SHA
    1347686 View commit details
    Browse the repository at this point in the history

Commits on Sep 14, 2022

  1. Remove backfilled check since we plan to go general anyway 

    See #13589 (comment)
    @MadLittleMods
    MadLittleMods committed Sep 14, 2022
    Configuration menu
    Copy the full SHA
    57182dc View commit details
    Browse the repository at this point in the history

  2. Merge branch 'develop' into madlittlemods/keep-track-when-we-tried-to… 

    …-backfill-an-event

Conflicts:
	synapse/storage/schema/__init__.py
    @MadLittleMods
    MadLittleMods committed Sep 14, 2022
    Configuration menu
    Copy the full SHA
    e58bc65 View commit details
    Browse the repository at this point in the history

  3. Move change to latest delta 73

    @MadLittleMods
    MadLittleMods committed Sep 14, 2022
    Configuration menu
    Copy the full SHA
    70019d2 View commit details
    Browse the repository at this point in the history