This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
Add --build-only option to complement.sh to prevent actually running Complement. #13158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reivilibre
force-pushed
the
rei/complement_build_only
branch
from
62715c5 to
3f203e1
Compare
… remember it better)
reivilibre
force-pushed
the
rei/complement_build_only
branch
from
3f203e1 to
1b86860
Compare
squahtx
approved these changes
Jul 7, 2022
scripts-dev/complement.sh
Outdated
Comment on lines
47
to
53
| -f, --fast | ||
| Skip rebuilding the docker images, and just use the most recent | ||
| 'complement-synapse:latest' image | ||
|
|
||
| --build-only | ||
| Only build the Docker images. Don't actually run Complement. | ||
|
|
There was a problem hiding this comment.
Do we want to document what happens when you have both --fast and --build-only? Not that you'd ever want to.
There was a problem hiding this comment.
I'll write that they conflict.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's a dual to the
-foption added in #13143.A potential use of this flag would be to make CI only build the image once rather than once per matrix run.
That would save us some CPU cycles on the workers (seems prudent considering they sometimes are all busy).