Skip to content
This repository was archived by the owner on Apr 26, 2024. It is now read-only.

Misc clean-up of push rules datastore #12856

Merged
merged 4 commits into from
May 25, 2022
+6 −11
Merged

Misc clean-up of push rules datastore #12856

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
1758e96
Remove unnecessary num_args params.
clokep May 24, 2022
37ec799
Use unique descriptions.
clokep May 24, 2022
a9cfe6e
Consistently cast enabled column.
clokep May 24, 2022
e20a9d8
Newsfragment
clokep May 24, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Use unique descriptions.
@clokep
clokep committed May 24, 2022
commit 37ec799b6ca9110363fe1a13fe4e6912b9161613
2 changes: 1 addition & 1 deletion synapse/storage/databases/main/push_rule.py
View file
Original file line number Diff line number Diff line change
@@ -174,7 +174,7 @@ async def get_push_rules_for_user(self, user_id: str) -> List[JsonDict]:
"conditions",
"actions",
),
desc="get_push_rules_enabled_for_user",
desc="get_push_rules_for_user",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or maybe this is meant to be the same description? It isn't really clear to me. Nothing else seems to call get_push_rules_enabled_for_user, which shares the description as this.

)

rows.sort(key=lambda row: (-int(row["priority_class"]), -int(row["priority"])))