-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for turning this into a PR Shay!
I would be interested in other's opinions on the topics of the docs laid out here.
- Flows of data through Synapse | ||
- Starts with a Request/BG Job/Module | ||
- Processing | ||
- Maybe Response |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Others should note that the non-markdown links have no effect in SUMMARY.md
, and are instead presented here as ideas for headings in pages / general notes.
They are left to give one an idea of what a page may contain, and will be removed/transferred to the parent doc pages before this PR merges.
- [Storage]() | ||
- What is current database schema? | ||
- Start by linking script that can compile full schema | ||
- Is there a tool that can visualize a postgres db? - Shay to check |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like this section 👍
Some copy-pastable snippets on how to explore the database would also be nice (cheat sheet):
psql synapse
: Open the postgres CLI against thesynapse
database\q
->enter
: To quit/exit\dt
: list tables\d+ issues
: list columns and indexes for issues tableCREATE TABLE board_labels();
: Create a table called board_labelsDROP TABLE insertion_event_extremeties
explain SELECT * FROM events WHERE depth = 1;
explain analyze SELECT * FROM events WHERE depth = 1;
-- #10245
- How does this work? | ||
- How is this helpful? | ||
- What's jaeger? | ||
- How do I create and mutate a span? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Definitely interested in how to work with and use all of the jaeger stuff!
@H-Shay, @anoadragon453 Do you think we should land this or close it? |
Fair question, I am interested in landing something like this, even if it doesn't go in the developer documentation (I think there were concerns with it becoming overwhelming?). Let's close this for now and maybe I'll flesh out something that could go in contrib or stand on it's own as an overview of Synapse. |
In our Internal Backend Chapter sync, we talked about instead documenting these items as long-form docstrings in the code base. I think this PR served as a good place to drum up ideas of things to document. We could now take it as inspiration for documentation to write alongside the code. For instance, if we want to write about Background Jobs, we should add to the docstring of the I think our current documentation suffers from us not looking at it frequently enough. Whereas if it were more intermixed with the code then we'd come across and update it more frequently. |
@anoadragon453 and I were discussing how to improve Synapse's developer documentation and we came up with an outline of topics that we would like to see added to the docs. This PR adds those topic stubs to the table of contents, with the hope that the team and contributors alike will then help fill in the stubs and improve the documentation going forwards.