Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Remove groups/communities from Synapse #12499

Closed
wants to merge 15 commits into from
Closed

Conversation

clokep
Copy link
Member

@clokep clokep commented Apr 19, 2022

This is a series of commits that removes the groups/communities code from Synapse.

I worked from the outside in, mostly, starting with the servlets & handlers, then the outgoing federation code, then the datastore code, then any other misc utilities.

It should generally be reviewable commit-by-commit, but the overall PR is rather massive. I can split this out into more logical pieces if people would prefer.

This needs to land in Synapse v1.59.0 or later.

A future PR will bump the database schema and remove the various groups tables.

Part of #11584.

@clokep clokep force-pushed the clokep/deprecate-groups-3 branch 3 times, most recently from 28d137e to 5147572 Compare April 19, 2022 17:10
Comment on lines +673 to 674
# Note that the groups key is no longer used and may have bogus values.
groups_key: int
Copy link
Member Author

@clokep clokep Apr 26, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm unsure if there is something better to do here? I did debate setting the default for groups_key to 0 so that we don't need to provide it when creating a StreamToken?

(In general, probably look closely over the changes to StreamToken...)

@clokep
Copy link
Member Author

clokep commented May 27, 2022

This has been mostly split into other PRs (see backlinks or #11584). I'm going to close this.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant