Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Add delay_cancellation utility function #12180

Merged
merged 11 commits into from
Mar 14, 2022
Merged

Add delay_cancellation utility function #12180

merged 11 commits into from
Mar 14, 2022

Commits on Mar 8, 2022

  1. Tweak docstring for stop_cancellation 

    Signed-off-by: Sean Quah <seanq@element.io>
    Sean Quah committed Mar 8, 2022
    Configuration menu
    Copy the full SHA
    fa97936 View commit details
    Browse the repository at this point in the history

  2. Quote Deferred type hint in stop_cancellation 

    Signed-off-by: Sean Quah <seanq@element.io>
    Sean Quah committed Mar 8, 2022
    Configuration menu
    Copy the full SHA
    b02f8e8 View commit details
    Browse the repository at this point in the history

  3. Refactor stop_cancellation tests to allow reuse for `delay_cancella… 

    …tion`

Signed-off-by: Sean Quah <seanq@element.io>
    Sean Quah committed Mar 8, 2022
    Configuration menu
    Copy the full SHA
    a9550f2 View commit details
    Browse the repository at this point in the history

  4. Add delay_cancellation utility function 

    `delay_cancellation` behaves like `stop_cancellation`, except it
delays `CancelledError`s until the original `Deferred` resolves.
This is handy for unifying cleanup paths and ensuring that uncancelled
coroutines don't use finished logcontexts.

Signed-off-by: Sean Quah <seanq@element.io>
    Sean Quah committed Mar 8, 2022
    Configuration menu
    Copy the full SHA
    6feaf20 View commit details
    Browse the repository at this point in the history

  5. Add delay_cancellation tests 

    Signed-off-by: Sean Quah <seanq@element.io>
    Sean Quah committed Mar 8, 2022
    Configuration menu
    Copy the full SHA
    e9210b2 View commit details
    Browse the repository at this point in the history

  6. Add newsfile 

    Signed-off-by: Sean Quah <seanq@element.io>
    Sean Quah committed Mar 8, 2022
    Configuration menu
    Copy the full SHA
    ab9b9e1 View commit details
    Browse the repository at this point in the history

Commits on Mar 9, 2022

  1. Parameterize CancellationWrapperTests with a string instead of lambdas

    Sean Quah committed Mar 9, 2022
    Configuration menu
    Copy the full SHA
    6de5030 View commit details
    Browse the repository at this point in the history

  2. Bake in all=True argument, since we've yet to come across a use cas… 

    …e for only delaying the first cancellation
    Sean Quah committed Mar 9, 2022
    Configuration menu
    Copy the full SHA
    543fafb View commit details
    Browse the repository at this point in the history

  3. Use a custom canceller

    Sean Quah committed Mar 9, 2022
    Configuration menu
    Copy the full SHA
    2542f74 View commit details
    Browse the repository at this point in the history

  4. Remove second cancel in logcontext test. Now that we're using a custo… 

    …m canceller, there's no point
    Sean Quah committed Mar 9, 2022
    Configuration menu
    Copy the full SHA
    a997133 View commit details
    Browse the repository at this point in the history

Commits on Mar 14, 2022

  1. Add comment about pause()

    Sean Quah committed Mar 14, 2022
    Configuration menu
    Copy the full SHA
    27274dc View commit details
    Browse the repository at this point in the history