Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Fix 500 error with Postgres when looking backwards with the MSC3030 /timestamp_to_event endpoint #12024

Merged
merged 3 commits into from
Feb 18, 2022
Merged

Fix 500 error with Postgres when looking backwards with the MSC3030 /timestamp_to_event endpoint #12024

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
fcc4445
Fix 500 error with Postgres when looking backwards with the MSC3030 /…
MadLittleMods Feb 18, 2022
19d69a1
Add changelog
MadLittleMods Feb 18, 2022
8fdf501
Merge branch 'develop' into madlittlemods/fix-forward-gap-db-query-co…
babolivier Feb 18, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions changelog.d/12024.bugfix
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Fix 500 error with Postgres when looking backwards with the [MSC3030](https://github.com/matrix-org/matrix-doc/pull/3030) `/timestamp_to_event?dir=b` endpoint.
2 changes: 1 addition & 1 deletion synapse/storage/databases/main/events_worker.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1854,7 +1854,7 @@ def is_event_next_to_gap_txn(txn: LoggingTransaction) -> bool:
forward_edge_query = """
SELECT 1 FROM event_edges
/* Check to make sure the event referencing our event in question is not rejected */
LEFT JOIN rejections ON event_edges.event_id == rejections.event_id
LEFT JOIN rejections ON event_edges.event_id = rejections.event_id
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

== is a valid comparison operator in SQLite but not in Postgres.

WHERE
event_edges.room_id = ?
AND event_edges.prev_event_id = ?
Expand Down