Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

SAML login fails since v1.12.0 if custom SAML module raises a RedirectException #7149

Closed
jaywink opened this issue Mar 26, 2020 · 2 comments
Closed

SAML login fails since v1.12.0 if custom SAML module raises a RedirectException #7149

jaywink opened this issue Mar 26, 2020 · 2 comments
Assignees
@jaywink
Labels
z-bug (Deprecated Label)

Comments

@jaywink
Copy link
Member

jaywink commented Mar 26, 2020 •
edited
Loading

Description

Mozilla SAML module raises a RedirectException to redirect a new user to a username picker: https://github.com/matrix-org/matrix-synapse-saml-mozilla/blob/master/matrix_synapse_saml_mozilla/mapping_provider.py#L162

Since v1.12.0 Synapse is catching this and rendering an error page instead: https://github.com/matrix-org/synapse/pull/7058/files#diff-4a1427aad5021dc55886911e28d9c941R120

Version information

Synapse v1.12.0
Matrix SYnapse SAML Mozilla v0.2.5
@jaywink jaywink added z-bug (Deprecated Label) mozilla labels Mar 26, 2020
@jaywink jaywink self-assigned this Mar 26, 2020
@jaywink
Copy link
Member Author

jaywink commented Mar 26, 2020

FYI fix pushed to the Mozilla Modular instance, PR upcoming.

jaywink added a commit that referenced this issue Mar 26, 2020
@jaywink
Allow RedirectResponse in SAML response handler
060e7dc 
Allow custom SAML handlers to redirect after processing an auth response.

Fixes #7149

Signed-off-by: Jason Robinson <jasonr@matrix.org>
@jaywink jaywink mentioned this issue Mar 26, 2020
Merged
@jaywink
Copy link
Member Author

jaywink commented Mar 26, 2020

Fixed in #7151

@jaywink jaywink closed this as completed Mar 26, 2020
phil-flex pushed a commit to phil-flex/synapse that referenced this issue Jun 16, 2020
@jaywink @phil-flex
Allow RedirectResponse in SAML response handler
b0513a3 
Allow custom SAML handlers to redirect after processing an auth response.

Fixes matrix-org#7149

Signed-off-by: Jason Robinson <jasonr@matrix.org>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@jaywink jaywink

Labels
z-bug (Deprecated Label)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jaywink