Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

it's possible to join an empty room over federation, resulting in a split-brain room #6958

Closed
richvdh opened this issue Feb 19, 2020 · 0 comments · Fixed by #7859
Closed

it's possible to join an empty room over federation, resulting in a split-brain room #6958

richvdh opened this issue Feb 19, 2020 · 0 comments · Fixed by #7859
Labels
z-bug (Deprecated Label) z-p2 (Deprecated Label)

Comments

@richvdh
Copy link
Member

richvdh commented Feb 19, 2020

we will happily accept make_join and send_join requests for an empty room; you then end up in a room on your lonesome. And then the target server thinks there is someone in the room even though there aren't any local members, and it's a horrible mess.
@richvdh richvdh mentioned this issue Feb 19, 2020
Closed
@richvdh richvdh added z-bug (Deprecated Label) z-p2 (Deprecated Label) labels Feb 20, 2020
@richvdh richvdh mentioned this issue Feb 20, 2020
Merged
@richvdh richvdh mentioned this issue Mar 3, 2020
Open
This was referenced Jul 13, 2020
Closed
Merged
richvdh added a commit that referenced this issue Jul 15, 2020
@richvdh
Reject attempts to join empty rooms over federation
df04bff 
We shouldn't allow others to make_join through us if we've left the room;
reject such attempts with a 404.

Fixes #7835. Fixes #6958.
richvdh added a commit that referenced this issue Jul 16, 2020
@richvdh
Reject attempts to join empty rooms over federation (#7859)
346476d 
We shouldn't allow others to make_join through us if we've left the room;
reject such attempts with a 404.

Fixes #7835. Fixes #6958.
@clokep clokep mentioned this issue Oct 6, 2021
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
z-bug (Deprecated Label) z-p2 (Deprecated Label)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Reject attempts to join empty rooms over federation matrix-org/synapse
1 participant
@richvdh