Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Fix removing pushers on python 3 #4250

Merged
merged 2 commits into from
Dec 4, 2018
Merged

Conversation

hawkowl
Copy link
Contributor

@hawkowl hawkowl commented Dec 3, 2018

No description provided.

@hawkowl hawkowl requested a review from a team December 3, 2018 11:28
@codecov-io
Copy link

codecov-io commented Dec 3, 2018

Codecov Report

Merging #4250 into develop will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #4250      +/-   ##
===========================================
- Coverage    73.55%   73.54%   -0.01%     
===========================================
  Files          299      299              
  Lines        29806    29806              
  Branches      4872     4872              
===========================================
- Hits         21923    21921       -2     
  Misses        6456     6456              
- Partials      1427     1429       +2
Impacted Files Coverage Δ
synapse/rest/client/v1/pusher.py 71.76% <100%> (ø) ⬆️
synapse/util/file_consumer.py 80.7% <0%> (-1.76%) ⬇️
synapse/handlers/user_directory.py 70.73% <0%> (-0.31%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c033242...998ba41. Read the comment docs.

Copy link
Member

@richvdh richvdh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm.

For future reference: what were the symptoms of the bug? The text of the exception would be useful for searches.

@richvdh
Copy link
Member

richvdh commented Dec 4, 2018

This is actually fixing #4222 aiui.

@richvdh richvdh merged commit a077e71 into develop Dec 4, 2018
@hawkowl hawkowl deleted the hawkowl/pusher-remove-py3 branch May 21, 2019 15:57
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants