unicode issue witth /_matrix/client/unstable/pusher/remove under py3

[michaelkaye]

Description

Requests to /_matrix/client/unstable/pusher/remove are not returning

Two bits to this problem - the failure itself and exception in logs, but also the error is not being returned as a response to the API request, instead the connection is dropped / not responded to.

Problem doesn't seem to be related to the client request, instead seems to be across the board.

Steps to reproduce

Remove a pusher. Get no reply from server (timeout) and this error in logs:

synapse.http.server - 112 - ERROR - GET-4749434 - Failed handle request via <function JsonResource._async_render ...  method='GET' uri='/_matrix/client/unstable/pushers/remove?access_token=<redacted>&app_id=m.email&pushkey=<redacted>
  File "/home/matrix/.synapse-py3/lib/python3.6/site-packages/twisted/internet/defer.py", line 654, in _runCallbacks
    current.result = callback(current.result, *args, **kw)
  File "/home/matrix/.synapse-py3/lib/python3.6/site-packages/twisted/internet/defer.py", line 1475, in gotResult
    _inlineCallbacks(r, g, status)
  File "/home/matrix/.synapse-py3/lib/python3.6/site-packages/twisted/internet/defer.py", line 1416, in _inlineCallbacks
    result = result.throwExceptionIntoGenerator(g)
  File "/home/matrix/.synapse-py3/lib/python3.6/site-packages/twisted/python/failure.py", line 491, in throwExceptionIntoGenerator
    return g.throw(self.type, self.value, self.tb)
--- <exception caught here> ---
  File "/home/matrix/synapse/synapse/http/server.py", line 81, in wrapped_request_handler
    yield h(self, request)
  File "/home/matrix/.synapse-py3/lib/python3.6/site-packages/twisted/internet/defer.py", line 1416, in _inlineCallbacks
    result = result.throwExceptionIntoGenerator(g)
  File "/home/matrix/.synapse-py3/lib/python3.6/site-packages/twisted/python/failure.py", line 491, in throwExceptionIntoGenerator
    return g.throw(self.type, self.value, self.tb)
  File "/home/matrix/synapse/synapse/http/server.py", line 316, in _async_render
    callback_return = yield callback(request, **kwargs)
  File "/home/matrix/.synapse-py3/lib/python3.6/site-packages/twisted/internet/defer.py", line 1418, in _inlineCallbacks
    result = g.send(result)
  File "/home/matrix/synapse/synapse/rest/client/v1/pusher.py", line 180, in on_GET
    request.write(PushersRemoveRestServlet.SUCCESS_HTML)
  File "/home/matrix/.synapse-py3/lib/python3.6/site-packages/twisted/web/server.py", line 238, in write
    http.Request.write(self, data)
  File "/home/matrix/.synapse-py3/lib/python3.6/site-packages/twisted/web/http.py", line 1139, in write
    self.channel.write(data)
  File "/home/matrix/.synapse-py3/lib/python3.6/site-packages/twisted/web/http.py", line 2397, in write
    self.transport.write(data)
  File "/home/matrix/.synapse-py3/lib/python3.6/site-packages/twisted/internet/_newtls.py", line 191, in write
    FileDescriptor.write(self, bytes)
  File "/home/matrix/.synapse-py3/lib/python3.6/site-packages/twisted/internet/abstract.py", line 349, in write
    raise TypeError("Data must not be unicode")
builtins.TypeError: Data must not be unicode

Version information

• Homeserver: Was this issue identified on matrix.org or another homeserver?

matrix.org

[richvdh]

fixed by #4250