Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Move MSC3030 /timestamp_to_event to stable endpoint #14390

Closed
MadLittleMods opened this issue Nov 7, 2022 · 2 comments · Fixed by #14471
Closed

Move MSC3030 /timestamp_to_event to stable endpoint #14390

MadLittleMods opened this issue Nov 7, 2022 · 2 comments · Fixed by #14471
Assignees
@MadLittleMods
Labels
A-Spec-Compliance places where synapse does not conform to the spec T-Task Refactoring, removal, replacement, enabling or disabling functionality, other engineering tasks.

Comments

@MadLittleMods
Copy link
Contributor

MadLittleMods commented Nov 7, 2022 •
edited
Loading

MSC3030 was merged which means it's now part of the stable Matrix spec.

Unstable /timestamp_to_event -> stable endpoint

We should update /_matrix/client/unstable/org.matrix.msc3030/rooms/<roomID>/timestamp_to_event?ts=<timestamp>&dir=<direction> to be at /_matrix/client/v1/rooms/<roomID>/timestamp_to_event?ts=<timestamp>&dir=<direction>.

Is v1 correct here? I don't get why we use v3 in some cases, etc

Advertising support

Also in terms of clients knowing whether the stable endpoint is supported now; I assume we have to wait until a Matrix 1.6 spec is cut to advertise support like #14184

But MSC3743 for standardizing the error response of unknown endpoints was also just merged which seems relevant. Clients could also check whether the /timestamp_to_event endpoint gives a 404 M_UNRECOGNIZED response to check for support.
@MadLittleMods MadLittleMods added the A-Spec-Compliance places where synapse does not conform to the spec label Nov 7, 2022
@squahtx squahtx added the T-Task Refactoring, removal, replacement, enabling or disabling functionality, other engineering tasks. label Nov 8, 2022
@clokep
Copy link
Member

clokep commented Nov 8, 2022 •
edited
Loading

Is v1 correct here? I don't get why we use v3 in some cases, etc

Yes, new endpoints get added as v1.

Also in terms of clients knowing whether the stable endpoint is supported now; I assume we have to wait until a Matrix 1.5 spec is cut to advertise support

This depends on whenever it gets merged into the spec, I think? There's not currently a spec PR for it. (Aka this isn't up to us!)

@MadLittleMods MadLittleMods self-assigned this Nov 16, 2022
MadLittleMods added a commit that referenced this issue Nov 16, 2022
@MadLittleMods
Move MSC3030 /timestamp_to_event endpoint to stable v1 location
0312ad3 
Fix #14390
This was referenced Nov 16, 2022
Merged
Closed
MadLittleMods added a commit that referenced this issue Nov 28, 2022
@MadLittleMods
Move MSC3030 /timestamp_to_event endpoint to stable v1 location (#1…
8f10c8b 
…4471)

Fix #14390

 - Client API: `/_matrix/client/unstable/org.matrix.msc3030/rooms/<roomID>/timestamp_to_event?ts=<timestamp>&dir=<direction>` -> `/_matrix/client/v1/rooms/<roomID>/timestamp_to_event?ts=<timestamp>&dir=<direction>`
 - Federation API: `/_matrix/federation/unstable/org.matrix.msc3030/timestamp_to_event/<roomID>?ts=<timestamp>&dir=<direction>` -> `/_matrix/federation/v1/timestamp_to_event/<roomID>?ts=<timestamp>&dir=<direction>`

Complement test changes: matrix-org/complement#559
@MadLittleMods MadLittleMods mentioned this issue Nov 29, 2022
Merged
4 tasks
H-Shay pushed a commit that referenced this issue Dec 13, 2022
@MadLittleMods @H-Shay
Move MSC3030 /timestamp_to_event endpoint to stable v1 location (#1…
f68b38c 
…4471)

Fix #14390

 - Client API: `/_matrix/client/unstable/org.matrix.msc3030/rooms/<roomID>/timestamp_to_event?ts=<timestamp>&dir=<direction>` -> `/_matrix/client/v1/rooms/<roomID>/timestamp_to_event?ts=<timestamp>&dir=<direction>`
 - Federation API: `/_matrix/federation/unstable/org.matrix.msc3030/timestamp_to_event/<roomID>?ts=<timestamp>&dir=<direction>` -> `/_matrix/federation/v1/timestamp_to_event/<roomID>?ts=<timestamp>&dir=<direction>`

Complement test changes: matrix-org/complement#559
@MadLittleMods
Copy link
Contributor Author

For reference: This landed as stable in Synapse 1.73.0 (search for #14471)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@MadLittleMods MadLittleMods

Labels
A-Spec-Compliance places where synapse does not conform to the spec T-Task Refactoring, removal, replacement, enabling or disabling functionality, other engineering tasks.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Move MSC3030 /timestamp_to_event endpoint to stable v1 location matrix-org/synapse
3 participants
@clokep @MadLittleMods @squahtx