Unread count keeps showing up for some rooms

[afranke]

Description

A private room I’m in keeps showing a (2) unread message count on client launch, both on Element Web and Android, even after I cleared cache.

Steps to reproduce

• got some messages in a specific private room
• read them on Element Web (the count disappears)
• left home, started Element Android, the count appeared again for that room but no new message was visible; opening the room here makes the count go away again
• went back home, started Element Web again, the same count was back again.
• read the room again, did a clear cache & reload, the count is back again.

This all happened within the past 24 hours. During that time, I also have had counts appear on direct conversations with no new events while the Web client was running. That is not as reproducible though.

Homeserver

matrix.org

Synapse Version

1.61.0

Installation Method

No response

Platform

🤷 matrix.org

Relevant log output

I don’t have access to that.

Anything else that would be useful to know?

No response

[DMRobertson]

got some messages in a specific private room

Are you able to share the room ID for debugging?

[afranke]

!zMjRxBhQzSpwVQMPLS:gnome.org

[kittykat]

I'm getting this issue annoyingly often for !TxHCEvTmqctXITtVQO:matrix.org last night and this morning

I would like to challenge the S-Minor label as the product is severely impaired if read rooms keep telling you that there are new messages in there wanting attention.

[erikjohnston]

Aha! I think I've spotted the problem. We don't correctly take into account the receipts at:

synapse/synapse/storage/databases/main/event_push_actions.py

Lines 1013 to 1026 in a962c5a

	sql = """
	SELECT user_id, room_id,
	coalesce(old.%s, 0) + upd.cnt,
	upd.stream_ordering
	FROM (
	SELECT user_id, room_id, count(*) as cnt,
	max(stream_ordering) as stream_ordering
	FROM event_push_actions
	WHERE ? < stream_ordering AND stream_ordering <= ?
	AND %s = 1
	GROUP BY user_id, room_id
	) AS upd
	LEFT JOIN event_push_summary AS old USING (user_id, room_id)
	"""

which is usually fine as we will have deleted push actions that have been read, except for highlights. Which is why we see the problem in DMs

[afranke]

The room I was reporting this for is not a DM but the latest message does indeed contain a highlight to me. It has also been edited, hence a (2) count. It checks out. 🙂