More forcefully close the connection.

matrix-org · Feb 16, 2021 · fb54d3c · fb54d3c
1 parent 0be5ce4
commit fb54d3c
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/synapse/http/client.py b/synapse/http/client.py
@@ -768,7 +768,9 @@ def dataReceived(self, data: bytes) -> None:
         # in the meantime.
         if self.max_size is not None and self.length >= self.max_size:
             self.deferred.errback(BodyExceededMaxSize())
-            self.transport.loseConnection()
+            # Close the connection (forcefully) since all the data will get
+            # discarded anyway.
+            self.transport.abortConnection()
 
     def connectionLost(self, reason: Failure) -> None:
         # If the maximum size was already exceeded, there's nothing to do.

diff --git a/tests/http/test_client.py b/tests/http/test_client.py
@@ -89,7 +89,7 @@ def test_additional_data(self):
         self.protocol.dataReceived(b"1234567890")
         self.assertIsInstance(self.deferred.result, Failure)
         self.assertIsInstance(self.deferred.result.value, BodyExceededMaxSize)
-        self.protocol.transport.loseConnection.assert_called_once()
+        self.protocol.transport.abortConnection.assert_called_once()
 
         # More data might have come in.
         self.protocol.dataReceived(b"1234567890")