Comment out dodgy log-kv (#12554)

matrix-org · Apr 26, 2022 · 6d89f12 · 6d89f12
1 parent c48ab37
commit 6d89f12
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 3 deletions.
diff --git a/changelog.d/12554.bugfix b/changelog.d/12554.bugfix
@@ -0,0 +1 @@
+Fix a bug introduced in Synapse 1.58.0rc1 where the main process could consume excessive amounts of CPU and memory handling sentry logging failures.
diff --git a/synapse/handlers/device.py b/synapse/handlers/device.py
@@ -683,9 +683,12 @@ async def _handle_new_device_update_async(self) -> None:
                             self.federation_sender.send_device_messages(
                                 host, immediate=False
                             )
-                            log_kv(
-                                {"message": "sent device update to host", "host": host}
-                            )
+                            # TODO: when called, this isn't in a logging context.
+                            # This leads to log spam, sentry event spam, and massive
+                            # memory usage. See #12552.
+                            # log_kv(
+                            #     {"message": "sent device update to host", "host": host}
+                            # )
 
                     if current_stream_id != stream_id:
                         # Clear the set of hosts we've already sent to as we're
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1 @@
		Fix a bug introduced in Synapse 1.58.0rc1 where the main process could consume excessive amounts of CPU and memory handling sentry logging failures.