Add missing idp_icon attributes to CasHandler and SamlHandler

matrix-org · Jan 20, 2021 · 50ef1cc · 50ef1cc
1 parent 3b2bf8e
commit 50ef1cc
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 0 deletions.
diff --git a/synapse/handlers/cas_handler.py b/synapse/handlers/cas_handler.py
@@ -80,6 +80,10 @@ def __init__(self, hs: "HomeServer"):
         # user-facing name of this auth provider
         self.idp_name = "CAS"
 
+        # we do not currently support icons for CAS auth, but this is required by
+        # the SsoIdentityProvider protocol type.
+        self.idp_icon = None
+
         self._sso_handler = hs.get_sso_handler()
 
         self._sso_handler.register_identity_provider(self)

diff --git a/synapse/handlers/saml_handler.py b/synapse/handlers/saml_handler.py
@@ -78,6 +78,10 @@ def __init__(self, hs: "HomeServer"):
         # user-facing name of this auth provider
         self.idp_name = "SAML"
 
+        # we do not currently support icons for SAML auth, but this is required by
+        # the SsoIdentityProvider protocol type.
+        self.idp_icon = None
+
         # a map from saml session id to Saml2SessionData object
         self._outstanding_requests_dict = {}  # type: Dict[str, Saml2SessionData]