Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Commit

Permalink
Comment dummy TURN parameters in default config
Browse files Browse the repository at this point in the history
This default config is parsed and used a base before the actual
config is overlaid, so with these values not commented out, the
code to detect when no turn params were set and refuse to generate
credentials was never firing because the dummy default was always set.
  • Loading branch information
dbkr committed Jul 11, 2018
1 parent 129ffd7 commit 36f4fd3
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 2 deletions.
1 change: 1 addition & 0 deletions changelog.d/3511.bugfix
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Don't generate TURN credentials if no TURN config options are set
4 changes: 2 additions & 2 deletions synapse/config/voip.py
Original file line number Diff line number Diff line change
Expand Up @@ -30,10 +30,10 @@ def default_config(self, **kwargs):
## Turn ##
# The public URIs of the TURN server to give to clients
turn_uris: []
#turn_uris: []
# The shared secret used to compute passwords for the TURN server
turn_shared_secret: "YOUR_SHARED_SECRET"
#turn_shared_secret: "YOUR_SHARED_SECRET"
# The Username and password if the TURN server needs them and
# does not use a token
Expand Down

0 comments on commit 36f4fd3

Please sign in to comment.