Fix incorrect log about not persisting duplicate state event. (#4776)

We were logging this when it was not true.
matrix-org · Mar 1, 2019 · 3064952 · 3064952
1 parent 1beebe9
commit 3064952
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 3 deletions.
diff --git a/changelog.d/4776.bugfix b/changelog.d/4776.bugfix
@@ -0,0 +1 @@
+Fix incorrect log about not persisting duplicate state event.
diff --git a/synapse/handlers/message.py b/synapse/handlers/message.py
@@ -436,10 +436,11 @@ def send_nonmember_event(self, requester, event, context, ratelimit=True):
 
         if event.is_state():
             prev_state = yield self.deduplicate_state_event(event, context)
-            logger.info(
-                "Not bothering to persist duplicate state event %s", event.event_id,
-            )
             if prev_state is not None:
+                logger.info(
+                    "Not bothering to persist state event %s duplicated by %s",
+                    event.event_id, prev_state.event_id,
+                )
                 defer.returnValue(prev_state)
 
         yield self.handle_new_client_event(
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1 @@
		Fix incorrect log about not persisting duplicate state event.