Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Commit

Permalink
Keep MacaroonInitException logged as exceptions
Browse files Browse the repository at this point in the history
Seems to be a legit application bug. See #12787.
  • Loading branch information
David Robertson committed May 18, 2022
1 parent d186cf5 commit 016fc20
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion synapse/handlers/oidc.py
Original file line number Diff line number Diff line change
Expand Up @@ -220,7 +220,7 @@ async def handle_oidc_callback(self, request: SynapseRequest) -> None:
session, state
)
except (MacaroonInitException, MacaroonDeserializationException, KeyError) as e:
logger.warning("Invalid session for OIDC callback: %s", e)
logger.exception("Invalid session for OIDC callback")
self._sso_handler.render_error(request, "invalid_session", str(e))
return
except MacaroonInvalidSignatureException as e:
Expand Down

0 comments on commit 016fc20

Please sign in to comment.