This repository has been archived by the owner on Apr 12, 2024. It is now read-only.
Change knocking room version to v7 #88
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The mypy CI failures are unrelated to this PR, and require pulling in lots of fixes from mainline to resolve: matrix-org/synapse#9513 Annoyingly this means we can't run the more interesting CI bits. |
anoadragon453
force-pushed
the
anoa/room_version_7
branch
from
affd0b9 to
6665ef3
Compare
|
I have verified that this passes SyTest and Complement tests locally (which took a while :( ). Fixing the CI will be done separately and involves pulling in a few fixes from mainline. |
This was referenced Mar 19, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Room version 7 has been defined as what MSC2403 follows, which has been implemented in
synapse-dinsic. Thus we're switching the room version from the unstable identifier to officially be v7: matrix-org/matrix-spec-proposals#2998