This repository has been archived by the owner on Apr 12, 2024. It is now read-only.
Update the DomainRuleChecker
module to the new callback and API
#111
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #110 - I've made this PR target #110's branch to make the diff more readable.
Note to reviewer:
Commits should be reviewable independently. Ideally the 1st commit should be its own PR, but it makes the
DomainRuleChecker
CI go red so I thought it made more sense to have it in here.Note to ops:
When deploying a Synapse version including this PR, a Synapse config change is required. All that's needed should be to move the config for the
DomainRuleChecker
from thespam_checker
section to themodules
one of the configuration file, since I also had to port the module to the new system. So this means this bit of configuration:Should become:
Note that this PR also removes support for the now useless
can_only_create_one_to_one_rooms
config option, but Synapse or the module won't fail if this option is kept around.