This repository has been archived by the owner on Apr 12, 2024. It is now read-only.
Create configurable ratelimiter for 3pid invites #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create a configurable rate-limiter for 3pid invites. 3pid invites already had a rate limiter, but it was locked to the per-user message rate limit. This changes it to that they are rate-limited based on a global option in
homeserver.yaml.This prevents per-user ratelimit overrides from affecting 3pid invites, but I don't think that would be a surprise to new users. I would find it odd if anyone was already relying on that behaviour, but if they are the changelog should make this change clear regardless.
Sytest PR matrix-org/sytest#740