CGO disabled to allow running on older distros #393
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
with CGO we are linking to whatever glibc is in ubuntu-latest, which may not be present in other distros (Think older Debian, Alpine) In addition, the docker build with alpine already (implicitly) does not use CGO, as CGO is still not supported with musl officially if I understand the following issue correctly: golang/go#19938 So disabling CGO in the released binaries and in the README instructions harmonizes the behaviour across docker and non-docker builds. Signed-off-by: Christoph Settgast <csett86_git@quicksands.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
with CGO we are linking to whatever glibc is in ubuntu-latest, which may
not be present in other distros (Think older Debian, Alpine)
In addition, the docker build with alpine already (implicitly) does not
use CGO, as CGO is still not supported with musl officially if I
understand the following issue correctly: golang/go#19938
So disabling CGO in the released binaries and in the README instructions harmonizes
the behaviour across docker and non-docker builds.
Pull Request Checklist
Signed-off-by: Christoph Settgast csett86_git@quicksands.de