Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the Docker image cross-compile without QEMU emulation #129

Merged
merged 2 commits into from
Sep 28, 2023

Conversation

sandhose
Copy link
Member

This does three things:

  • Bump all dependencies & disable the pyo3 feature by default (because I had issues with old versions of maturin & openssl)
  • Make the Docker image cross-compile without QEMU emulation
  • Add a build cache on the Docker image

@sandhose sandhose requested a review from a team as a code owner September 12, 2023 13:03
Copy link
Member

@clokep clokep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not really sure how to test this -- should we kick off a manual build to see it work? (I'm unsure if that'll push the image / cause it to get used automatically.)

Overall it looks plausible though.

synapse_auto_compressor/pyproject.toml Show resolved Hide resolved
@sandhose
Copy link
Member Author

I'm not really sure how to test this -- should we kick off a manual build to see it work? (I'm unsure if that'll push the image / cause it to get used automatically.)

You can try building the image locally for a foreign platform, e.g. docker build --platform=linux/arm64 ., and it should work if you have a recent enough docker?

Copy link
Member

@clokep clokep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seemed to work OK.

@clokep clokep merged commit 4b9f2e2 into main Sep 28, 2023
4 checks passed
@clokep clokep deleted the quenting/cross-compile-ci branch September 28, 2023 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants