-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix image not running in K8s (ROSA) #24
Conversation
I don't know if this solves it. Trying to solve the container exiting with error code `243`. `npm` throws `243` for any command you try to run with it. Here is how to get into the container while the entrypoint normally errors. ``` $ oc run -i --tty --image=ghcr.io/matrix-org/matrix-public-archive/matrix-public-archive:main mpa-test2 --port=3050 --restart=Never --env="DOMAIN=cluster" --command /bin/bash $ npm start $ echo $? 243 ```
@@ -4,8 +4,6 @@ RUN mkdir -p /app | |||
|
|||
WORKDIR /app | |||
|
|||
RUN npm install npm@^8 --location=global |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Doesn't solve the problem but I think we can get rid of this anyway. I added it before because I saw a warning about the package-lock.json
made in an earlier version and to do the one-time upgrade, etc. I didn't see the warning in the latest build anyway.
@@ -1,11 +1,9 @@ | |||
FROM node:16.15-buster-slim | |||
FROM node:16.14.2-buster-slim |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems to have fixed it 🤷 . Here are the packaged versions:
$ node --version
v16.14.2
$ npm --version
8.5.0
Previously it was using:
$ node --version
v16.15.1
$ npm --version
8.11.0
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems like it could be either of these issues. Both are 8.6.0
+ problems as well which lines up with the npm
version available in each base image.
- [BUG]
npm
refuses to run if the home directory is inaccessible npm/cli#4769 - [BUG] npm silently fails when unable to write cache directory npm/cli#4996
- Specific comment about breaking stuff in k8s for other people, [BUG] npm silently fails when unable to write cache directory npm/cli#4996 (comment)
Fix image not running in K8s (ROSA)
Trying to solve the container exiting with error code
243
.npm
throws243
for any command you try to run with it.Here is how to get into the container while the entrypoint normally errors.
Why does the same image work in Docker?
Root cause
Seems like it could be either of these issues. Both are
8.6.0
+ problems as well which lines up with thenpm
version available in each base image.npm
refuses to run if the home directory is inaccessible npm/cli#4769