Convert to async/await #101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@reivilibre Looks like we need to do some CI updates before reviewing this. |
|
This needs a rebase. 😄 |
clokep
approved these changes
Sep 2, 2020
Comment on lines
+198
to
+200
| Makes an awaitable, suitable for mocking an `async` function. | ||
| This uses Futures as they can be awaited multiple times so can be returned | ||
| to multiple callers. |
There was a problem hiding this comment.
Looks like this would be a nice change to put into synapse so that we don't have to use side_effect + lambda in a lot of places.
Co-authored-by: Patrick Cloke <clokep@users.noreply.github.com>
Co-authored-by: Patrick Cloke <clokep@users.noreply.github.com>
Signed-off-by: Olivier Wilkinson (reivilibre) <olivier@librepush.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #100 .
Would like to know if I can avoid reverting to
deferin the tests.Edit: would also be interested in having someone actually run this to check it works... the tests pass, at least.