Clarify that relations recursion should be capped at a certain depth #1854
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Johannes Marbach <n0-0ne+github@mailbox.org>
clokep
approved these changes
Jun 13, 2024
53 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to the capped nature of the recursion the phrase "all events" is not necessarily correct in all cases. For the same reason, I also thought it's better to contract the two paragraphs because the depth is only relevant for the
recurse=truecase.While at it, I also tried to convert the keywords to #1782 (though I'm not sure if this would better be applied holistically in this file).
Pull Request Checklist
Preview: https://pr1854--matrix-spec-previews.netlify.app