Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make clearer in the example that the fallback prefix sequence should be repeated for each line #1690

Merged
merged 2 commits into from
Jan 15, 2024

Conversation

Konubinix
Copy link
Contributor

@Konubinix Konubinix commented Dec 4, 2023

I needed to read the spec twice to make sure it was the case.

Also, I encountered an implementation of matrix that added the sequence only for the first line.

I believe that making the first example of the chapter show several lines will make less likely such mistakes in the future.

Preview: https://pr1690--matrix-spec-previews.netlify.app

@Konubinix Konubinix requested a review from a team as a code owner December 4, 2023 09:44
@richvdh
Copy link
Member

richvdh commented Dec 5, 2023

I'm sorry you found it a chore

@richvdh richvdh changed the title chore: Make clearer in the example that the fallback prefix sequence should be repeated for each line Make clearer in the example that the fallback prefix sequence should be repeated for each line Dec 5, 2023
Copy link
Member

@richvdh richvdh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution. Please take a look at the contributing guide, particularly with respect to changelog entries and sign-off.

@Konubinix
Copy link
Contributor Author

Konubinix commented Dec 6, 2023 via email

@Konubinix
Copy link
Contributor Author

IIUC, the only thing I needed to do in that particular case was to sign off my
commit, right?

So, I did it :-)

Please let me know if there is something I missed.

@Konubinix
Copy link
Contributor Author

I understand that updating the changelog is done only when the API changes.

@richvdh richvdh requested a review from a team December 11, 2023 12:57
@richvdh
Copy link
Member

richvdh commented Dec 19, 2023

Yeah the wording is unclear; apologies. (#1697 should improve it.)

Please could you create changelogs/client_server/newsfragments/1690.clarification with a brief summary (Clarify example for reply fallbacks. or somesuch).

…should be repeated for each line

Signed-off-by: Samuel Loury <konubinixweb@gmail.com>
@Konubinix
Copy link
Contributor Author

Konubinix commented Dec 20, 2023 via email

@richvdh richvdh self-requested a review January 10, 2024 18:01
Copy link
Member

@richvdh richvdh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the contribution! Sorry the review took a while.

@richvdh richvdh merged commit 1d35e7a into matrix-org:main Jan 15, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants