Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the changelog entry checker script to check newsfragment file extension #1542

Merged
merged 2 commits into from
May 31, 2023

Conversation

anoadragon453
Copy link
Member

@anoadragon453 anoadragon453 commented May 25, 2023

This PR updates the script that the newsfragment check CI step uses in order to verify that changelog entries have one of the known newsfragment file extensions.

Inspired by failing to write a valid extension in #1465 :)

matrix-spec on  appservice-ping-spec [$!?] took 5.7s …
➜ ./scripts/check-newsfragments 
+++ Checking newsfragments for PR #
ERROR: newsfragment changelogs/client_server/newsfragments/1465.clarifications does not have one of the required file extensions for a changelog entry: .new, .feature, .clarification, .breaking, .deprecation

matrix-spec on  appservice-ping-spec [$!?] …
➜ mv changelogs/client_server/newsfragments/1465.clarification{s,}

matrix-spec on  appservice-ping-spec [$✘!?] …
➜ ./scripts/check-newsfragments                                   
+++ Checking newsfragments for PR #

Preview: https://pr1542--matrix-spec-previews.netlify.app

@anoadragon453 anoadragon453 marked this pull request as ready for review May 25, 2023 10:36
@anoadragon453 anoadragon453 requested a review from a team as a code owner May 25, 2023 10:37
Copy link
Member

@turt2live turt2live left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@anoadragon453 anoadragon453 merged commit c64a616 into main May 31, 2023
@anoadragon453 anoadragon453 deleted the anoa/newsfragment_extension_check branch May 31, 2023 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants