Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add standard error responses (MSC3743). #1347

Merged
merged 6 commits into from
Nov 22, 2022
Merged

Add standard error responses (MSC3743). #1347

merged 6 commits into from
Nov 22, 2022

Conversation

clokep
Copy link
Member

@clokep clokep commented Nov 17, 2022 •
edited by github-actions bot
Loading

Spec PR for matrix-org/matrix-spec-proposals#3743.

I wasn't sure if there was a single spot I should put this or if we should just put it into each separate bit of the spec. I chose the latter since there didn't seem to be a good consolidated spot.

This isn't quite as clear as I'd like it to be (as it should apply to everything under /_matrix).

Preview: https://pr1347--matrix-spec-previews.netlify.app

@clokep clokep marked this pull request as ready for review November 17, 2022 14:56
@clokep clokep requested a review from a team as a code owner November 17, 2022 14:56
@turt2live turt2live mentioned this pull request Nov 17, 2022
Merged
anoadragon453
anoadragon453 requested changes Nov 22, 2022
View reviewed changes
Copy link
Member

@anoadragon453 anoadragon453 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me on the whole! I think the place you chose to put the information in each spec is appropriate.

Just some small fixes below, nothing major.

content/application-service-api.md Outdated Show resolved Hide resolved
content/client-server-api/_index.md Outdated Show resolved Hide resolved
content/application-service-api.md Outdated Show resolved Hide resolved
content/application-service-api.md Outdated Show resolved Hide resolved
content/identity-service-api.md Outdated Show resolved Hide resolved
clokep and others added 4 commits November 22, 2022 10:41
@clokep @anoadragon453
Fix typos.
a4dd703 
Co-authored-by: Andrew Morgan <1342360+anoadragon453@users.noreply.github.com>
@clokep @anoadragon453
Split up sentences for clarity.
bbe7e33 
Co-authored-by: Andrew Morgan <1342360+anoadragon453@users.noreply.github.com>
@clokep
More typo fixes.
9b037ba
@clokep
Use a before error codes.
f8a91df
@clokep clokep requested a review from anoadragon453 November 22, 2022 15:49
anoadragon453
anoadragon453 approved these changes Nov 22, 2022
View reviewed changes
Copy link
Member

@anoadragon453 anoadragon453 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thank you!

@anoadragon453 anoadragon453 merged commit eeb4304 into matrix-org:main Nov 22, 2022
@clokep clokep deleted the std-err-resp branch November 22, 2022 15:55
@zecakeh zecakeh mentioned this pull request Dec 14, 2022
Closed
34 tasks
clokep added a commit to clokep/matrix-spec that referenced this pull request May 3, 2023
@clokep
Add standard error responses (MSC3743). (matrix-org#1347)
ba0ea17
@S7evinK S7evinK mentioned this pull request Oct 2, 2023
Open
11 tasks
@Johennes Johennes mentioned this pull request Jun 18, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anoadragon453 anoadragon453 anoadragon453 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@clokep @anoadragon453