Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add link checker to CI #1329

Merged
merged 5 commits into from
Nov 8, 2022
Merged

Add link checker to CI #1329

merged 5 commits into from
Nov 8, 2022

Conversation

richvdh
Copy link
Member

@richvdh richvdh commented Nov 8, 2022

To ensure that we don't accumulate dead links, add a step in CI to check the rendered output for broken links.

Based on #1330.

Also includes some tweaks to ensure that we have unique anchors where we need them. See the commit comment on
9e83605.

Preview: https://pr1329--matrix-spec-previews.netlify.app

A bunch of broken links I found
The link checker doesn't understand that we dynamically re-assign element IDs
at load time, so was failing for a few links that were technically valid
(though presumably still broken for any client not using JS).

Work around this by manually setting a few anchors, linking to other nearby
bits of text, or just changing heading titles.
@richvdh richvdh changed the title Add htmltest github action Add link checker to CI Nov 8, 2022
@richvdh richvdh marked this pull request as ready for review November 8, 2022 19:29
@richvdh richvdh requested a review from a team as a code owner November 8, 2022 19:29
@richvdh richvdh merged commit b9952f1 into main Nov 8, 2022
@richvdh richvdh deleted the rav/htmltest branch November 8, 2022 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants