Skip to content

Commit

Permalink
Remove declared-invalid invite->knock restriction from auth rules (#…
Browse files Browse the repository at this point in the history
…1175)

* Remove declared-invalid `invite->knock` restriction from auth rules

* Changelog

* real changelog
  • Loading branch information
turt2live authored Aug 2, 2022
1 parent f24cad1 commit b36d4ef
Show file tree
Hide file tree
Showing 4 changed files with 4 additions and 6 deletions.
1 change: 1 addition & 0 deletions changelogs/room_versions/newsfragments/1175.clarification
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
For room versions 7 through 10: Clarify that `invite->knock` is actually a legal transition.
3 changes: 1 addition & 2 deletions content/rooms/fragments/v8-auth-rules.md
Original file line number Diff line number Diff line change
Expand Up @@ -118,8 +118,7 @@ The rules are as follows:
7. If `membership` is `knock`:
1. If the `join_rule` is anything other than `knock`, reject.
2. If `sender` does not match `state_key`, reject.
3. If the `sender`'s current membership is not `ban`, `invite`,
or `join`, allow.
3. If the `sender`'s current membership is not `ban` or `join`, allow.
4. Otherwise, reject.
8. Otherwise, the membership is unknown. Reject.
5. If the `sender`'s current membership state is not `join`, reject.
Expand Down
3 changes: 1 addition & 2 deletions content/rooms/v10.md
Original file line number Diff line number Diff line change
Expand Up @@ -193,8 +193,7 @@ The rules are as follows:
If the `join_rule` is anything other than `knock` or
`knock_restricted`, reject.
2. If `sender` does not match `state_key`, reject.
3. If the `sender`'s current membership is not `ban`, `invite`,
or `join`, allow.
3. If the `sender`'s current membership is not `ban` or `join`, allow.
4. Otherwise, reject.
8. Otherwise, the membership is unknown. Reject.
5. If the `sender`'s current membership state is not `join`, reject.
Expand Down
3 changes: 1 addition & 2 deletions content/rooms/v7.md
Original file line number Diff line number Diff line change
Expand Up @@ -135,8 +135,7 @@ The rules are as follows:
6. If `membership` is `knock`:
1. If the `join_rule` is anything other than `knock`, reject.
2. If `sender` does not match `state_key`, reject.
3. If the `sender`'s current membership is not `ban`, `invite`,
or `join`, allow.
3. If the `sender`'s current membership is not `ban` or `join`, allow.
4. Otherwise, reject.
7. Otherwise, the membership is unknown. Reject.
5. If the `sender`'s current membership state is not `join`, reject.
Expand Down

0 comments on commit b36d4ef

Please sign in to comment.