Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MSC4132: Deprecate Linking to an Event Against a Room Alias #4132

Merged
merged 5 commits into from
May 12, 2024
Merged

MSC4132: Deprecate Linking to an Event Against a Room Alias #4132

merged 5 commits into from
May 12, 2024

Conversation

pixlwave
Copy link
Member

@pixlwave pixlwave commented Apr 17, 2024 •
edited by richvdh
Loading

@pixlwave pixlwave marked this pull request as ready for review April 17, 2024 11:52
@ara4n ara4n changed the title Deprecate Linking to an Event Against a Room Alias MSC4132: Deprecate Linking to an Event Against a Room Alias Apr 17, 2024
@ara4n ara4n added proposal A matrix spec change proposal kind:maintenance MSC which clarifies/updates existing spec labels Apr 17, 2024
@turt2live turt2live added the needs-implementation This MSC does not have a qualifying implementation for the SCT to review. The MSC cannot enter FCP. label Apr 17, 2024
turt2live
turt2live reviewed Apr 17, 2024
View reviewed changes
proposals/4132-deprecate-event-on-room-alias-uris.md
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Implementation requirements:

None, in my opinion. This MSC deprecates a feature and already appears to be unimplemented (for the most part).

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just pointing out that it seems that Nheko does this as of 0.11.3, which is currently the latest release.

@turt2live turt2live removed the needs-implementation This MSC does not have a qualifying implementation for the SCT to review. The MSC cannot enter FCP. label Apr 17, 2024
@turt2live
Copy link
Member

... and because I haven't sent enough comments in the last few minutes: the deprecation requirements can be clarified concurrent to checkbox gathering, imo. I see no reason to delay this MSC.

@mscbot fcp merge

@mscbot
Copy link
Collaborator

mscbot commented Apr 17, 2024 •
edited by dbkr
Loading

Team member @mscbot has proposed to merge this. The next step is review by the rest of the tagged people:

Concerns:

  • outstanding comments

Once at least 75% of reviewers approve (and there are no outstanding concerns), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up!

See this document for information about what commands tagged team members can give me.

@mscbot mscbot added proposed-final-comment-period Currently awaiting signoff of a majority of team members in order to enter the final comment period. disposition-merge labels Apr 17, 2024
@pixlwave @turt2live
Pin the spec links
6d79453 
Co-authored-by: Travis Ralston <travpc@gmail.com>
@pixlwave
Copy link
Member Author

... and because I haven't sent enough comments in the last few minutes: the deprecation requirements can be clarified concurrent to checkbox gathering, imo. I see no reason to delay this MSC.

Just for clarification as I haven't done this before, I think this is saying its fine to update the proposal based on the comments whilst SCT members are looking at it?

@pixlwave
Copy link
Member Author

Updated taking all of the comments above into consideration.

@turt2live
Copy link
Member

... and because I haven't sent enough comments in the last few minutes: the deprecation requirements can be clarified concurrent to checkbox gathering, imo. I see no reason to delay this MSC.

Just for clarification as I haven't done this before, I think this is saying its fine to update the proposal based on the comments whilst SCT members are looking at it?

Yes, sorry. The proposal can be updated in all kinds of ways up until Final Comment Period (FCP) actually starts - when 8/10 people check their boxes and no concerns are formally raised. Things which SCT members believe should prevent acceptance of the MSC are raised via @mscbot concern. Everything else is non-blocking, though may still feel important to address.

@turt2live
Copy link
Member

(though please avoid force pushing, as it makes review harder. We squash all the commits down to a single commit upon acceptance)

@pixlwave
Copy link
Member Author

My bad, good to know you squash 👍

@dbkr
Copy link
Member

dbkr commented May 1, 2024

@mscbot concern outstanding comments

@mscbot mscbot added the unresolved-concerns This proposal has at least one outstanding concern label May 1, 2024
@turt2live turt2live requested a review from dbkr May 3, 2024 23:25
@dbkr
Copy link
Member

dbkr commented May 7, 2024

@mscbot resolve outstanding comments

@mscbot mscbot removed the unresolved-concerns This proposal has at least one outstanding concern label May 7, 2024
@mscbot
Copy link
Collaborator

mscbot commented May 7, 2024

🔔 This is now entering its final comment period, as per the review above. 🔔

@mscbot mscbot added final-comment-period This MSC has entered a final comment period in interest to approval, postpone, or delete in 5 days. and removed proposed-final-comment-period Currently awaiting signoff of a majority of team members in order to enter the final comment period. labels May 7, 2024
@dbkr dbkr removed their request for review May 7, 2024 08:42
@mscbot
Copy link
Collaborator

mscbot commented May 12, 2024

The final comment period, with a disposition to merge, as per the review above, is now complete.

@mscbot mscbot added finished-final-comment-period and removed disposition-merge final-comment-period This MSC has entered a final comment period in interest to approval, postpone, or delete in 5 days. labels May 12, 2024
@turt2live turt2live merged commit 2534644 into matrix-org:main May 12, 2024
1 check passed
@turt2live turt2live added spec-pr-missing Proposal has been implemented and is being used in the wild but hasn't yet been added to the spec and removed finished-final-comment-period labels May 12, 2024
@ara4n ara4n mentioned this pull request May 16, 2024
Merged
@turt2live
Copy link
Member

Spec PR: matrix-org/matrix-spec#1823

@turt2live turt2live added spec-pr-in-review A proposal which has been PR'd against the spec and is in review and removed spec-pr-missing Proposal has been implemented and is being used in the wild but hasn't yet been added to the spec labels May 16, 2024
@ara4n
Copy link
Member

ara4n commented May 30, 2024

ironically, i just found a permalink indexed by room alias in the wild: element-hq/element-web#2150 (comment)

@richvdh
Copy link
Member

richvdh commented Jun 4, 2024

merged! 🎉

@richvdh richvdh added merged A proposal whose PR has merged into the spec! and removed spec-pr-in-review A proposal which has been PR'd against the spec and is in review labels Jun 4, 2024
@zecakeh zecakeh mentioned this pull request Jun 7, 2024
Closed
53 tasks
@zecakeh zecakeh mentioned this pull request Jun 21, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clokep clokep clokep left review comments

@turt2live turt2live turt2live left review comments

@ara4n ara4n ara4n left review comments

@MTRNord MTRNord MTRNord left review comments

@bmarty bmarty bmarty left review comments

@erikjohnston erikjohnston erikjohnston left review comments

@KitsuneRal KitsuneRal KitsuneRal left review comments

@Kladki Kladki Kladki left review comments

Assignees
No one assigned
Labels
kind:maintenance MSC which clarifies/updates existing spec merged A proposal whose PR has merged into the spec! proposal A matrix spec change proposal
Projects
Spec Core Team Backlog
Status: Done to some definition
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.