Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MSC3773: Notifications for threads #3773

Merged
merged 11 commits into from
Sep 20, 2022
Merged

MSC3773: Notifications for threads #3773

merged 11 commits into from
Sep 20, 2022

Conversation

clokep
Copy link
Member

@clokep clokep commented Apr 15, 2022 •
edited
Loading

@turt2live turt2live added push proposal A matrix spec change proposal client-server Client-Server API kind:core MSC which is critical to the protocol's success needs-implementation This MSC does not have a qualifying implementation for the SCT to review. The MSC cannot enter FCP. labels Apr 15, 2022
@clokep clokep mentioned this pull request Apr 25, 2022
Closed
6 tasks
@clokep clokep mentioned this pull request Jul 25, 2022
Closed
11 tasks
This was referenced Aug 3, 2022
Closed
Closed
@clokep clokep marked this pull request as ready for review August 8, 2022 18:53
dbkr
dbkr approved these changes Aug 9, 2022
View reviewed changes
Copy link
Member

@dbkr dbkr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With my client hat on, this looks fine, and is simple and solve the problem in question. One minor nitpick could be a note saying that it only seeks to address the counts in the sync response, rather than content of any actual notifications sent (which I think is the correct decision).

This was referenced Aug 18, 2022
Closed
Closed
Closed
@mscbot
Copy link
Collaborator

mscbot commented Sep 18, 2022

The final comment period, with a disposition to merge, as per the review above, is now complete.

@mscbot mscbot added finished-final-comment-period and removed disposition-merge final-comment-period This MSC has entered a final comment period in interest to approval, postpone, or delete in 5 days. labels Sep 18, 2022
@turt2live turt2live merged commit 9d80dcb into main Sep 20, 2022
@turt2live turt2live added spec-pr-missing Proposal has been implemented and is being used in the wild but hasn't yet been added to the spec and removed finished-final-comment-period labels Sep 20, 2022
@turt2live turt2live self-assigned this Sep 26, 2022
@turt2live turt2live mentioned this pull request Sep 27, 2022
Merged
@turt2live
Copy link
Member

Spec PR: matrix-org/matrix-spec#1255

@turt2live turt2live added spec-pr-in-review A proposal which has been PR'd against the spec and is in review and removed spec-pr-missing Proposal has been implemented and is being used in the wild but hasn't yet been added to the spec labels Sep 27, 2022
@turt2live
Copy link
Member

Merged 🎉

@turt2live turt2live added merged A proposal whose PR has merged into the spec! and removed spec-pr-in-review A proposal which has been PR'd against the spec and is in review labels Sep 28, 2022
This was referenced Sep 30, 2022
Closed
Closed
Merged
This was referenced Oct 3, 2022
Merged
Closed
@MTRNord MTRNord mentioned this pull request Oct 12, 2022
Closed
This was referenced Oct 17, 2022
Closed
Closed
netbsd-srcmastr pushed a commit to NetBSD/pkgsrc that referenced this pull request Oct 29, 2022
chat/matrix-synapse: Update to 1.71.1
b3710ef 
Upstream changes:

Synapse 1.70.1 (2022-10-28)
===========================

(bugfixes)


Synapse 1.70.0 (2022-10-26)
===========================

Features
--------

- Support for
  [MSC3856](matrix-org/matrix-spec-proposals#3856):
  threads list
  API. ([\#13394](matrix-org/synapse#13394),
  [\#14171](matrix-org/synapse#14171),
  [\#14175](matrix-org/synapse#14175))

- Support for thread-specific notifications & receipts
  ([MSC3771](matrix-org/matrix-spec-proposals#3771)
  and
  [MSC3773](matrix-org/matrix-spec-proposals#3773)). ([\#13776](matrix-org/synapse#13776),
  [\#13824](matrix-org/synapse#13824),
  [\#13877](matrix-org/synapse#13877),
  [\#13878](matrix-org/synapse#13878),
  [\#14050](matrix-org/synapse#14050),
  [\#14140](matrix-org/synapse#14140),
  [\#14159](matrix-org/synapse#14159),
  [\#14163](matrix-org/synapse#14163),
  [\#14174](matrix-org/synapse#14174),
  [\#14222](matrix-org/synapse#14222))

- Stop fetching missing `prev_events` after we already know their
  signature is
  invalid. ([\#13816](matrix-org/synapse#13816))

- Send application service access tokens as a header (and query
  parameter). Implements
  [MSC2832](matrix-org/matrix-spec-proposals#2832). ([\#13996](matrix-org/synapse#13996))

- Ignore server ACL changes when generating pushes. Implements
  [MSC3786](matrix-org/matrix-spec-proposals#3786). ([\#13997](matrix-org/synapse#13997))

- Experimental support for redirecting to an implementation of a
  [MSC3886](matrix-org/matrix-spec-proposals#3886)
  HTTP rendezvous
  service. ([\#14018](matrix-org/synapse#14018))

- The `/relations` endpoint can now be used on
  workers. ([\#14028](matrix-org/synapse#14028))

- Advertise support for Matrix 1.3 and 1.4 on
  `/_matrix/client/versions`. ([\#14032](matrix-org/synapse#14032),
  [\#14184](matrix-org/synapse#14184))

- Improve validation of request bodies for the [Device
  Management](https://spec.matrix.org/v1.4/client-server-api/#device-management)
  and [MSC2697 Device
  Dehyrdation](matrix-org/matrix-spec-proposals#2697)
  client-server API
  endpoints. ([\#14054](matrix-org/synapse#14054))

- Experimental support for
  [MSC3874](matrix-org/matrix-spec-proposals#3874):
  Filtering threads from the `/messages`
  endpoint. ([\#14148](matrix-org/synapse#14148))

- Improve the validation of the following PUT endpoints:
  [`/directory/room/{roomAlias}`](https://spec.matrix.org/v1.4/client-server-api/#put_matrixclientv3directoryroomroomalias),
  [`/directory/list/room/{roomId}`](https://spec.matrix.org/v1.4/client-server-api/#put_matrixclientv3directorylistroomroomid)
  and
  [`/directory/list/appservice/{networkId}/{roomId}`](https://spec.matrix.org/v1.4/application-service-api/#put_matrixclientv3directorylistappservicenetworkidroomid). ([\#14179](matrix-org/synapse#14179))


Deprecations and Removals
-------------------------

- Remove the experimental implementation of
  [MSC3772](matrix-org/matrix-spec-proposals#3772). ([\#14094](matrix-org/synapse#14094))

- Remove the unstable identifier for
  [MSC3715](matrix-org/matrix-spec-proposals#3715). ([\#14106](matrix-org/synapse#14106),
  [\#14146](matrix-org/synapse#14146))
@germain-gg germain-gg mentioned this pull request Jan 30, 2023
Merged
3 tasks
@jdauphant jdauphant mentioned this pull request Apr 3, 2023
Open
@clokep clokep deleted the clokep/threads-notifications branch May 17, 2023 12:21
@S7evinK S7evinK mentioned this pull request Oct 2, 2023
Open
14 tasks
@matrixbot matrixbot mentioned this pull request Nov 1, 2024
Open
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erikjohnston erikjohnston erikjohnston left review comments

@t3chguy t3chguy t3chguy left review comments

@anoadragon453 anoadragon453 anoadragon453 left review comments

@Johennes Johennes Johennes left review comments

@germain-gg germain-gg germain-gg left review comments

@turt2live turt2live turt2live approved these changes

@dbkr dbkr dbkr approved these changes

Assignees

@turt2live turt2live

Labels
client-server Client-Server API kind:core MSC which is critical to the protocol's success merged A proposal whose PR has merged into the spec! proposal A matrix spec change proposal push
Projects
Spec Core Team Backlog
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@clokep @turt2live @erikjohnston @mscbot @anoadragon453 @germain-gg @dbkr @Johennes @t3chguy @ara4n