Remove definition of Event for /notifications
#3525
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The documentation for the `/notifications` API had its own special definition of what an Event was, which was used nowhere else. The common definition isn't perfect, but it *is* common, so it gives us a better starting place for improvement.
KitsuneRal
approved these changes
Nov 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The documentation for the
/notificationsAPI had its own special definition of what an Event was, which was used nowhere else.The common definition isn't perfect, but it is common, so it gives us a better starting place for improvement.
We shouldn't merge this until #3524 lands, as otherwise
prev_contentdisappears from the definition.Preview: https://pr3525--matrix-org-previews.netlify.app